Address PR comments [4]

zeta-chain · Nov 22, 2024 · e3f43d8 · e3f43d8
1 parent 6036675
commit e3f43d8
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,10 @@
 # CHANGELOG
 
+## Unreleased
+
+## Refactor
+* [3170](https://github.com/zeta-chain/node/pull/3170) - revamp TSS package in zetaclient
+
 ## v23.0.0
 
 ### Features
@@ -25,7 +30,6 @@
 * [3125](https://github.com/zeta-chain/node/pull/3125) - drop support for header proofs
 * [3131](https://github.com/zeta-chain/node/pull/3131) - move app context update from zetacore client
 * [3137](https://github.com/zeta-chain/node/pull/3137) - remove chain.Chain from zetaclientd config
-* [3170](https://github.com/zeta-chain/node/pull/3170) - revamp TSS package in zetaclient
 
 ### Fixes
 

diff --git a/zetaclient/metrics/metrics.go b/zetaclient/metrics/metrics.go
@@ -43,11 +43,11 @@ var (
 		Help:      "Count of getLogs per chain",
 	}, []string{"chain"})
 
-	// TssNodeBlamePerPubKey is a counter that contains the number of tss node blame per pubkey
-	TssNodeBlamePerPubKey = promauto.NewCounterVec(prometheus.CounterOpts{
+	// TSSNodeBlamePerPubKey is a counter that contains the number of tss node blame per pubkey
+	TSSNodeBlamePerPubKey = promauto.NewCounterVec(prometheus.CounterOpts{
 		Namespace: ZetaClientNamespace,
 		Name:      "tss_node_blame_count",
-		Help:      "Tss node blame counter per pubkey",
+		Help:      "TSS node blame counter per pubkey",
 	}, []string{"pubkey"})
 
 	// RelayerKeyBalance is a gauge that contains the relayer key balance of the chain

diff --git a/zetaclient/tss/config.go b/zetaclient/tss/config.go
@@ -14,6 +14,7 @@ import (
 )
 
 const (
+	// Port is the default port for go-tss server.
 	Port    = 6668
 	Version = "0.14.0"
 	Algo    = tsscommon.ECDSA

diff --git a/zetaclient/tss/keygen.go b/zetaclient/tss/keygen.go
@@ -207,7 +207,7 @@ func (k *keygenCeremony) performKeygen(ctx context.Context, keygenTask observert
 
 	// increment blame counter
 	for _, node := range res.Blame.BlameNodes {
-		metrics.TssNodeBlamePerPubKey.WithLabelValues(node.Pubkey).Inc()
+		metrics.TSSNodeBlamePerPubKey.WithLabelValues(node.Pubkey).Inc()
 	}
 
 	blameDigest, err := digestReq(req)

diff --git a/zetaclient/tss/setup.go b/zetaclient/tss/setup.go
@@ -152,7 +152,7 @@ func Setup(ctx context.Context, p SetupProps, logger zerolog.Logger) (*Service,
 		WithMetrics(ctx, p.Zetacore, &Metrics{
 			ActiveMsgsSigns:    metrics.NumActiveMsgSigns,
 			SignLatency:        metrics.SignLatency,
-			NodeBlamePerPubKey: metrics.TssNodeBlamePerPubKey,
+			NodeBlamePerPubKey: metrics.TSSNodeBlamePerPubKey,
 		}),
 	)
 	if err != nil {