feedback updates

zeta-chain · Dec 6, 2024 · 8afffab · 8afffab
1 parent 56a323b
commit 8afffab
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 15 deletions.
diff --git a/proto/zetachain/zetacore/observer/query.proto b/proto/zetachain/zetacore/observer/query.proto
@@ -169,7 +169,7 @@ service Query {
   // Queries operational flags
   rpc OperationalFlags(QueryOperationalFlagsRequest)
       returns (QueryOperationalFlagsResponse) {
-    option (google.api.http).get = "/zeta-chain/observer/opertaionalFlags";
+    option (google.api.http).get = "/zeta-chain/observer/operationalFlags";
   }
 }
 

diff --git a/x/observer/client/cli/tx_update_operational_flags.go b/x/observer/client/cli/tx_update_operational_flags.go
@@ -3,7 +3,6 @@ package cli
 import (
 	"encoding/json"
 	"os"
-	"path/filepath"
 
 	"github.com/cosmos/cosmos-sdk/client"
 	"github.com/cosmos/cosmos-sdk/client/flags"
@@ -31,11 +30,6 @@ func CmdUpdateOperationalFlags() *cobra.Command {
 			restartHeight, _ := flagSet.GetInt64("restart-height")
 
 			if file != "" {
-				file, err := filepath.Abs(file)
-				if err != nil {
-					return err
-				}
-				file = filepath.Clean(file)
 				input, err := os.ReadFile(file) // #nosec G304
 				if err != nil {
 					return err

diff --git a/x/observer/types/message_update_operational_flags.go b/x/observer/types/message_update_operational_flags.go
@@ -44,5 +44,10 @@ func (msg *MsgUpdateOperationalFlags) ValidateBasic() error {
 	if _, err := sdk.AccAddressFromBech32(msg.Creator); err != nil {
 		return cosmoserrors.Wrapf(sdkerrors.ErrInvalidAddress, "invalid creator address (%s)", err)
 	}
+
+	if msg.OperationalFlags.RestartHeight < 0 {
+		return cosmoserrors.Wrap(sdkerrors.ErrInvalidRequest, "restart height cannot be negative")
+	}
+
 	return nil
 }
diff --git a/x/observer/types/query.pb.go b/x/observer/types/query.pb.go
diff --git a/x/observer/types/query.pb.gw.go b/x/observer/types/query.pb.gw.go