coderabbit feedback

zeta-chain · Dec 19, 2024 · 76989af · 76989af
1 parent 8993c28
commit 76989af
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/proto/zetachain/zetacore/observer/tx.proto b/proto/zetachain/zetacore/observer/tx.proto
@@ -2,7 +2,6 @@ syntax = "proto3";
 package zetachain.zetacore.observer;
 
 import "gogoproto/gogo.proto";
-import "google/protobuf/field_mask.proto";
 import "zetachain/zetacore/observer/blame.proto";
 import "zetachain/zetacore/observer/crosschain_flags.proto";
 import "zetachain/zetacore/observer/observer.proto";

diff --git a/x/observer/types/operational.go b/x/observer/types/operational.go
@@ -17,7 +17,7 @@ func (f *OperationalFlags) Validate() error {
 	if f.SignerBlockTimeOffset != nil {
 		signerBlockTimeOffset := *f.SignerBlockTimeOffset
 		if signerBlockTimeOffset < 0 {
-			return ErrOperationalFlagsRestartHeightNegative
+			return ErrOperationalFlagsSignerBlockTimeOffsetNegative
 		}
 		if signerBlockTimeOffset > signerBlockTimeOffsetLimit {
 			return cosmoserrors.Wrapf(ErrOperationalFlagsSignerBlockTimeOffsetLimit, "(%s)", signerBlockTimeOffset)

diff --git a/x/observer/types/operational_test.go b/x/observer/types/operational_test.go
@@ -39,7 +39,7 @@ func TestOperationalFlags_Validate(t *testing.T) {
 			of: types.OperationalFlags{
 				SignerBlockTimeOffset: ptr.Ptr(-time.Second),
 			},
-			errContains: types.ErrOperationalFlagsRestartHeightNegative.Error(),
+			errContains: types.ErrOperationalFlagsSignerBlockTimeOffsetNegative.Error(),
 		},
 		{
 			name: "signer offset limit exceeded",