-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Solana Web3.js Library Supply Chain Attack #224
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -55,7 +55,7 @@ | |||||
"@coral-xyz/anchor": "0.30.0", | ||||||
"@solana-developers/helpers": "^2.4.0", | ||||||
"@solana/spl-memo": "^0.2.5", | ||||||
"@solana/web3.js": "^1.95.2", | ||||||
"@solana/web3.js": "^1.95.5", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Version constraint still allows vulnerable versions The current update to Apply this fix to explicitly prevent installation of vulnerable versions: - "@solana/web3.js": "^1.95.5",
+ "@solana/web3.js": "~1.95.5", This change uses the tilde (~) operator to only allow patch updates within the 1.95.x range up to but not including 1.95.6, effectively blocking the compromised versions. 📝 Committable suggestion
Suggested change
|
||||||
"@zetachain/protocol-contracts": "11.0.0-rc3" | ||||||
} | ||||||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -55,7 +55,7 @@ | |||||
"@coral-xyz/anchor": "0.30.0", | ||||||
"@solana-developers/helpers": "^2.4.0", | ||||||
"@solana/spl-memo": "^0.2.5", | ||||||
"@solana/web3.js": "^1.95.2", | ||||||
"@solana/web3.js": "^1.95.5", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Version constraint still allows vulnerable versions The current update to Apply this fix to explicitly prevent installation of vulnerable versions: - "@solana/web3.js": "^1.95.5",
+ "@solana/web3.js": "~1.95.5", This change uses the tilde (~) operator to only allow patch updates within the 1.95.x range up to but not including 1.95.6, effectively blocking the compromised versions. 📝 Committable suggestion
Suggested change
|
||||||
"@zetachain/protocol-contracts": "11.0.0-rc3" | ||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Version constraint still allows vulnerable versions
The current update to
"@solana/web3.js": "^1.95.5"
does not effectively prevent the installation of the compromised versions (1.95.6 and 1.95.7). The caret (^) in the version constraint allows updates to all future patch versions, potentially exposing the project to the supply chain attack.Apply this fix to explicitly prevent installation of vulnerable versions:
This change uses the tilde (~) operator to only allow patch updates within the 1.95.x range up to but not including 1.95.6, effectively blocking the compromised versions.
📝 Committable suggestion