Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix nix build #82

Merged
merged 2 commits into from
Jul 24, 2024
Merged

ci: fix nix build #82

merged 2 commits into from
Jul 24, 2024

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Jul 23, 2024

store directory was missing from sources and gomod2nix needed to be run.

Also update the diff patterns so CI isn't missed in needed cases.

Last known good commit: 61d0400

Closes #68

Summary by CodeRabbit

  • New Features

    • Expanded build configuration to include additional source files from the store directory, enhancing the application's resource scope.
    • Updated the Ethereum Go client module to a new version, improving dependency management.
    • Enhanced linting coverage by including Go module files for better code quality.
  • Bug Fixes

    • Corrected dependency resolution by specifying a replacement for the Ethereum module, ensuring better compatibility and stability.
  • Chores

    • Modified GitHub Actions workflows to monitor additional file types for linting and testing, improving integration processes.

Copy link

coderabbitai bot commented Jul 23, 2024

Walkthrough

The changes enhance the Nix build configuration by modifying the source directory regex to include the store directory, allowing for the inclusion of additional resources in application builds. Additionally, the Ethereum Go client module version is updated in gomod2nix.toml, reflecting a specialized variant and altering dependency management. These updates collectively aim to improve the environment setup for running integration tests.

Changes

Files Change Summary
default.nix Updated regex in src to include store directory in the build process.
gomod2nix.toml Changed Ethereum client module version to v1.10.26-spc, updated hash, and added a replaced field.
.github/workflows/lint.yml Added go.mod, go.sum, and gomod2nix.toml to the linting file patterns.
.github/workflows/test.yml Added *.nix to the monitored file patterns for the test workflow.

Assessment against linked issues

Objective Addressed Explanation
Add pkgs included by us (#[68])
Fix nix to run integration tests (#[68]) It's unclear if integration tests are fully functional with the current changes.

🐰 In the garden where changes bloom,
New paths emerge, dispelling gloom.
With regex widened, and clients anew,
Our build's now richer, a joyful brew!
Hops and skips through the code we dance,
Integration awaits, let’s take a chance! 🍃


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gartnera gartnera requested review from lumtis, fbac and skosito July 23, 2024 17:37
@gartnera gartnera self-assigned this Jul 23, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3106ecc and fdf3fc0.

Files selected for processing (2)
  • default.nix (1 hunks)
  • gomod2nix.toml (1 hunks)
Additional comments not posted (2)
default.nix (1)

20-20: LGTM! The regex pattern update correctly includes the store directory.

The updated regex pattern now includes the store directory, which aligns with the PR's objective to fix the Nix build by addressing the missing store directory.

gomod2nix.toml (1)

203-205: LGTM! The Ethereum Go client module updates are correct.

The module version has been updated to "v1.10.26-spc", the hash has been updated, and a replaced field has been added to reflect a specialized variant of the module.

However, verify that the replacement module github.com/zeta-chain/go-ethereum is correctly integrated and functioning as expected.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fdf3fc0 and e2b9e15.

Files selected for processing (2)
  • .github/workflows/lint.yml (1 hunks)
  • .github/workflows/test.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/test.yml
Additional comments not posted (3)
.github/workflows/lint.yml (3)

84-84: Good addition: Including go.mod in linting.

Adding go.mod to the linting process ensures that changes to the Go module file are also checked, maintaining consistency and correctness in dependency management.


85-85: Good addition: Including go.sum in linting.

Adding go.sum to the linting process ensures that changes to the Go checksum file are also checked, maintaining the integrity of dependencies.


86-86: Good addition: Including gomod2nix.toml in linting.

Adding gomod2nix.toml to the linting process ensures that changes to the Nix configuration file are also checked, maintaining the correctness of the Nix build configuration.

Copy link
Contributor

@fbac fbac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gartnera!

@lumtis lumtis merged commit b08e280 into main Jul 24, 2024
24 checks passed
@gartnera gartnera deleted the fix-nix-build branch July 24, 2024 14:42
@coderabbitai coderabbitai bot mentioned this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: fix nix
3 participants