Ajout des liens vers les contenus dans l'état indiqué #6631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,16 +71,18 @@ <h2 class="subtitle"> | |||
| {% if content.sha_public == commit.hexsha or content.sha_validation == commit.hexsha or content.sha_beta == commit.hexsha or content.sha_draft == commit.hexsha %} | |||
| <ul class="unstyled-list"> | |||
| {% if content.sha_validation == commit.hexsha %} | |||
| <li>{% trans "Validation" %}</li> | |||
| {% url "content:validation-view" pk=content.pk slug=content.slug as url_validation %} | |||
| <a href="{{ url_validation }}"><li>{% trans "Validation" %}</li></a> | |||
There was a problem hiding this comment.
La QA semble avoir été faite un peu vite, des erreurs d’inattention (je suppose) s’étant glissées.
Ce code HTML, et tous ses semblables, sont invalides (les éléments li doivent être des enfants directs de ul). Il aurait fallu inverser l’imbrication des balises li et a pour l'ensemble des liens ajoutés.
There was a problem hiding this comment.
Effectivement. On n'a pas de vérification automatique sur les templates, ça aiderait à attraper ces trucs, parce que je t'avoue que je ne réflechis absolument pas à la validité du HTML quand je teste ces choses-là.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrôle qualité