Place 'built-in' Slice files at the front of the 'references' list. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
slicecparses files in the order you provide them (see icerpc/slicec#694)... this PR fixes #49.Previously,
slicecparsed files in a non-deterministic order, making it impossible to control which files get parsed first.Now that this is no longer the case, this PR changes our logic so that we always parse the built-in-Slice-files first.
This way, if a user does have a conflict with these Slice definitions, the redefinition error will appear in their files.
(
slicecwill first parse the built-in-files, and unless we really screwed up, there will be no redefinitions in them)