-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove -c option from udp endpoints in C# #3218
Conversation
{ | ||
_endpoint = endpoint; | ||
_instance = instance; | ||
_state = connect ? StateNeedConnect : StateNotConnected; | ||
_state = StateNotConnected; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A server transceiver (incoming = true) starts in the StateNotConnected state and remains in that state.
A client transceiver (incoming = false) starts in the StateNeedConnect state and goes up to StateConnected. It never reaches StateNotConnected.
{ | ||
Debug.Assert(incoming); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: do we create a new Connection and potentially ConnectionInfo for each incoming UDP request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the IncomingConnectionFactory I believe there is a single udp Connection created by the factory constructor. But then caching the info object wouldn't be correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we create a new connection for each request. And udp bi-dir relies on these per-request connections:
ice/csharp/test/Ice/udp/AllTests.cs
Line 200 in 41307f9
Console.Out.Write("testing udp bi-dir connection... "); |
This PR from the undocumented "-c" option from udp endpoints in C#.
This was a server-endpoint option. For client option, the behavior is always "connect".