Replace Task.Delay in C# tests #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
approved these changes
Nov 27, 2024
| { | ||
| await Task.Delay(10); | ||
| } | ||
| public override Task opAsyncDispatchAsync(Ice.Current current) => Task.CompletedTask; |
There was a problem hiding this comment.
Shouldn't we use Task.Yield here too, to test asynchronous completion?
There was a problem hiding this comment.
As far as I can tell, that's not what this test is testing.
| @@ -1,829 +1,825 @@ | |||
| // Copyright (c) ZeroC, Inc. | |||
|
|
|||
| namespace Ice | |||
| namespace Ice.operations.AMD; | |||
There was a problem hiding this comment.
Is there any fixes in this file other than switching to a file scoped namespace?
There was a problem hiding this comment.
Yes, removed async and await Task.Delay(0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3189.