Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionInfo fixes in C++ and C# #3197

Merged
merged 2 commits into from
Nov 26, 2024
Merged

ConnectionInfo fixes in C++ and C# #3197

merged 2 commits into from
Nov 26, 2024

Conversation

bernardnormier
Copy link
Member

@bernardnormier bernardnormier commented Nov 26, 2024 •
edited
Loading

The PR:

  • clarifies the internal Transceiver::getInfo operation
  • clears the cached connection info when a new adapter is set on a connection

@bernardnormier bernardnormier changed the title Change semantics of ConnectionInfo::adapterName in C= Change semantics of ConnectionInfo::adapterName in C++ and C# Nov 26, 2024
@bernardnormier bernardnormier marked this pull request as draft November 26, 2024 20:29
pepone
pepone approved these changes Nov 26, 2024
View reviewed changes
cpp/src/Ice/ConnectionI.cpp Outdated Show resolved Hide resolved
@bernardnormier bernardnormier changed the title Change semantics of ConnectionInfo::adapterName in C++ and C# ConnectionInfo fixes in C++ and C# Nov 26, 2024
@bernardnormier bernardnormier marked this pull request as ready for review November 26, 2024 20:46
@bernardnormier bernardnormier mentioned this pull request Nov 26, 2024
Merged
@bernardnormier bernardnormier merged commit 0288df0 into zeroc-ice:main Nov 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentoi bentoi Awaiting requested review from bentoi

@pepone pepone Awaiting requested review from pepone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernardnormier @pepone