Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang format workflow #1920

Merged
merged 20 commits into from
Mar 8, 2024
Merged

Add clang format workflow #1920

merged 20 commits into from
Mar 8, 2024

Conversation

externl
Copy link
Member

@externl externl commented Mar 8, 2024

No description provided.

@externl externl changed the title Add cpplint workflow Add clang format workflow Mar 8, 2024
@externl externl requested review from bernardnormier and pepone March 8, 2024 16:18
@externl externl marked this pull request as ready for review March 8, 2024 16:18
pepone
pepone reviewed Mar 8, 2024
View reviewed changes
.github/workflows/clang_format.yml Outdated Show resolved Hide resolved
.github/workflows/clang_format.yml Outdated Show resolved Hide resolved
cpp/src/Ice/LocatorInfo.cpp Outdated Show resolved Hide resolved
.github/workflows/clang_format.yml Show resolved Hide resolved
@externl externl requested a review from pepone March 8, 2024 17:10
@externl
Copy link
Member Author

externl commented Mar 8, 2024 •
edited
Loading

I pushed changes with the new BinPackArguments setting. Thoughts @pepone? It's the only way I could fine to get it to not pack function call arguments. But it also undoes when we have it already.

I prefer one argument per line if the function call is being broken onto multiple lines.

@externl externl merged commit 94ed832 into zeroc-ice:main Mar 8, 2024
7 checks passed
@externl externl deleted the cpplint branch March 8, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernardnormier bernardnormier bernardnormier approved these changes

@pepone pepone pepone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@externl @pepone @bernardnormier