Update udp connection info + test (#3228)

cpp/src/Ice/UdpTransceiver.cpp

@@ -474,10 +474,6 @@ IceInternal::UdpTransceiver::toString() const
         Address localAddr;
         fdToLocalAddress(_fd, localAddr);
         s << "local address = " << addrToString(localAddr);
-        if (isAddressValid(_peerAddr))
-        {
-            s << "\nremote address = " << addrToString(_peerAddr);
-        }
     }
     else
     {
@@ -538,21 +534,16 @@ IceInternal::UdpTransceiver::getInfo(bool incoming, string adapterName, string c
             int localPort;
             addrToAddressAndPort(localAddr, localAddress, localPort);
 
-            string remoteAddress;
-            int remotePort = 0;
-            if (isAddressValid(_peerAddr))
-            {
-                addrToAddressAndPort(_peerAddr, remoteAddress, remotePort);
-            }
-
+            // Since this info is cached in the Connection object shared by all the clients, we don't store the
+            // remote address/port of the latest client in this info.
             return make_shared<UDPConnectionInfo>(
                 incoming,
                 std::move(adapterName),
                 std::move(connectionId),
                 std::move(localAddress),
                 localPort,
-                std::move(remoteAddress),
-                remotePort,
+                "", // remoteAddress
+                -1, // remotePort
                 std::move(mcastAddress),
                 mcastPort,
                 _rcvSize,

cpp/test/Ice/udp/AllTests.cpp

@@ -168,6 +168,8 @@ allTests(Test::TestHelper* helper)
 #endif
 
     cout << "testing udp bi-dir connection... " << flush;
+    // This feature is only half-implemented. In particular, we maintain a single Connection object on the server side
+    // that gets updated each time we receive a new request.
     obj->ice_getConnection()->setAdapter(adapter);
     nRetry = 5;
     while (nRetry-- > 0)

csharp/src/Ice/Internal/UdpTransceiver.cs

@@ -521,14 +521,17 @@ public ConnectionInfo getInfo(bool incoming, string adapterName, string connecti
             if (_state == StateNotConnected) // a server connection
             {
                 Debug.Assert(incoming);
+
+                // Since this info is cached in the Connection object shared by all the clients, we don't store the
+                // remote address/port of the latest client in this info.
                 return new UDPConnectionInfo(
                     incoming,
                     adapterName,
                     connectionId,
                     Network.endpointAddressToString(localEndpoint),
                     Network.endpointPort(localEndpoint),
-                    _peerAddr is not null ? Network.endpointAddressToString(_peerAddr) : "",
-                    _peerAddr is not null ? Network.endpointPort(_peerAddr) : -1,
+                    remoteAddress: "",
+                    remotePort: -1,
                     _mcastAddr is not null ? Network.endpointAddressToString(_mcastAddr) : "",
                     _mcastAddr is not null ? Network.endpointPort(_mcastAddr) : -1,
                     _rcvSize,

csharp/test/Ice/udp/AllTests.cs

@@ -199,6 +199,8 @@ public static async Task allTests(global::Test.TestHelper helper)
         Console.Out.WriteLine("ok");
 
         Console.Out.Write("testing udp bi-dir connection... ");
+        // This feature is only half-implemented. In particular, we maintain a single Connection object on the server
+        // side that gets updated each time we receive a new request.
         Console.Out.Flush();
         obj.ice_getConnection().setAdapter(adapter);
         nRetry = 5;

java/src/com.zeroc.ice/src/main/java/com/zeroc/Ice/UdpTransceiver.java

@@ -198,9 +198,6 @@ public String toString() {
                     "local address = "
                             + Network.addrToString(
                                     (java.net.InetSocketAddress) socket.getLocalSocketAddress());
-            if (_peerAddr != null) {
-                s += "\nremote address = " + Network.addrToString(_peerAddr);
-            }
         } else {
             s = Network.fdToString(_fd);
         }
@@ -247,14 +244,17 @@ public ConnectionInfo getInfo(boolean incoming, String adapterName, String conne
 
             if (_state == StateNotConnected) {
                 assert _incoming;
+
+                // Since this info is cached in the Connection object shared by all the clients,
+                // we don't store the remote address/port of the latest client in this info.
                 return new UDPConnectionInfo(
                         incoming,
                         adapterName,
                         connectionId,
                         socket.getLocalAddress().getHostAddress(),
                         socket.getLocalPort(),
-                        _peerAddr != null ? _peerAddr.getAddress().getHostAddress() : "",
-                        _peerAddr != null ? _peerAddr.getPort() : -1,
+                        "", // remoteAddress
+                        -1, // remotePort
                         _mcastAddr != null ? _mcastAddr.getAddress().getHostAddress() : "",
                         _mcastAddr != null ? _mcastAddr.getPort() : -1,
                         rcvSize,

java/test/src/main/java/test/Ice/udp/AllTests.java

@@ -179,6 +179,9 @@ public static void allTests(test.TestHelper helper) {
             out.println("ok");
 
             out.print("testing udp bi-dir connection... ");
+            // This feature is only half-implemented. In particular, we maintain a single
+            // Connection object on the server side that gets updated each time we receive
+            // a new request.
             out.flush();
             obj.ice_getConnection().setAdapter(adapter);
             nRetry = 5;