fix: Restrict registration for owners of parent domains

[JamesEarle]

This makes it so you can only mint free subdomains if you own both the ERC721 token and the domain name in the record held by the ZNSRegistry, solving a potential issue that comes from a token being transferred in a sale on a third party exchange like OpenSea and that new owner not calling to reclaim their ownership of the domain. In this case, the previous owner would still be allowed to register subdomains for free.

[codecov]

Codecov Report

Merging #99 (d9aeffa) into development (8f67434) will increase coverage by 0.00%.
Report is 2 commits behind head on development.
The diff coverage is 100.00%.

Additional details and impacted files

@@             Coverage Diff              @@
##           development      #99   +/-   ##
============================================
  Coverage        99.80%   99.80%           
============================================
  Files               11       11           
  Lines              512      515    +3     
  Branches           127      128    +1     
============================================
+ Hits               511      514    +3     
  Misses               1        1           

[openzeppelin-code]

fix: Restrict registration for owners of parent domains

Generated at commit: d9aeffa5d160520163a456da804b0003d68eaef0

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	0 0 0 5 22 27
Dependencies	Critical High Medium Low Note Total	0 0 0 2 27 29

---

For more details view the full report in OpenZeppelin Code Inspector

[Whytecrowe]

comments