-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Coupon mintlist system #101
base: development
Are you sure you want to change the base?
Conversation
…e correct address
fix: Coupon mintlist system
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #101 +/- ##
============================================
Coverage 99.80% 99.80%
============================================
Files 11 12 +1
Lines 512 514 +2
Branches 127 128 +1
============================================
+ Hits 511 513 +2
Misses 1 1 |
string memory version | ||
) EIP712(name, version) {} | ||
|
||
function hashCoupon(Coupon memory coupon) public view override returns (bytes32) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be a pure function?
// idea around creating signer in `hashCoupon` or similar | ||
// then storing that data, and in recreation we have to get the address that signed? | ||
// how do we bulk sign? | ||
address private constant COUPON_SIGNER = 0x15d34AAf54267DB7D7c367839AAf71A00a2C6A65; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this should be a state var.
This change creates a mintlist system based on a verified signer we control having signed off on each "coupon" that an account can use in registration of a subdomain. If the user presents a message that was not signed by our dedicated coupon signer (TBD what account this is) then it is not considered a valid claim.
What still needs to happen
Considerations: