Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Silabs LDMA initial support #82611

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Add Silabs LDMA initial support #82611

merged 5 commits into from
Dec 16, 2024

Conversation

Martinhoff-maker
Copy link
Contributor

This PR adds Silabs LDMA driver which allows 4 actually implemented Silabs boards (sltb010a,slwrb4180a,xg24_dk2601b and xg27_dk2602a) to use DMA.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Hello @Martinhoff-maker, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

jerome-pouiller
jerome-pouiller reviewed Dec 6, 2024
View reviewed changes
soc/silabs/Kconfig Outdated Show resolved Hide resolved
drivers/dma/Kconfig.silabs Outdated Show resolved Hide resolved
drivers/dma/Kconfig.silabs Outdated Show resolved Hide resolved
drivers/dma/CMakeLists.txt Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
tests/drivers/dma/chan_blen_transfer/boards/sltb010a.conf Outdated Show resolved Hide resolved
asmellby
asmellby reviewed Dec 6, 2024
View reviewed changes
dts/arm/silabs/efr32mg.dtsi Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
@Martinhoff-maker
soc: silabs: add dma support in soc kconfig
f23558d 
Update Kconfig to support LDMA.

Signed-off-by: Martin Hoff <[email protected]>
@Martinhoff-maker Martinhoff-maker force-pushed the silabs_dma_driver branch 4 times, most recently from 0b62f5e to 143d02f Compare December 10, 2024 08:19
@Martinhoff-maker Martinhoff-maker marked this pull request as ready for review December 10, 2024 10:33
@zephyrbot zephyrbot added area: DMA Direct Memory Access platform: Silabs Silicon Labs labels Dec 10, 2024
jerome-pouiller
jerome-pouiller reviewed Dec 10, 2024
View reviewed changes
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Show resolved Hide resolved
@Martinhoff-maker Martinhoff-maker force-pushed the silabs_dma_driver branch 2 times, most recently from 29305ae to a8a8c7b Compare December 11, 2024 08:00
jhedberg
jhedberg previously approved these changes Dec 11, 2024
View reviewed changes
jhedberg
jhedberg previously approved these changes Dec 12, 2024
View reviewed changes
jerome-pouiller
jerome-pouiller previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@jerome-pouiller jerome-pouiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

asmellby
asmellby requested changes Dec 12, 2024
View reviewed changes
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
drivers/dma/dma_silabs_ldma.c Outdated Show resolved Hide resolved
@Martinhoff-maker
drivers: dma: Add initial support for silabs LDMA
8448860 
Initial support of silabs LDMA using hal library em_ldma.

Signed-off-by: Martin Hoff <[email protected]>
@Martinhoff-maker
dts: arm/silabs: add dma node for efr32(mg2x/bg2x)
594a781 
Update dts for efr32mg2x and efr32bg2x board that support silabs ldma

Signed-off-by: Martin Hoff <[email protected]>
@Martinhoff-maker
tests: dma: add silabs boards conf files
264bb55 
Added sltb010a,slwrb4180a,xg24_dk2601b and xg27_dk2602a boards files
to run chan_blen_transfer, loop_transfer and scatter_gather tests.

Signed-off-by: Martin Hoff <[email protected]>
@Martinhoff-maker
boards: silabs: update board description about dma
71eb053 
Update sltb010a,slwrb4180a, xg24_dk2601b and xg27_dk2602a boards
descriptions in order to run dma test. Also update boards
documentations.

Signed-off-by: Martin Hoff <[email protected]>
@kartben kartben merged commit 31b6c25 into zephyrproject-rtos:main Dec 16, 2024
29 checks passed
@github-actions GitHub Actions
Copy link

Hi @Martinhoff-maker!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmellby asmellby asmellby approved these changes

@jerome-pouiller jerome-pouiller jerome-pouiller approved these changes

@jhedberg jhedberg jhedberg approved these changes

@teburd teburd teburd approved these changes

@mnkp mnkp Awaiting requested review from mnkp

@rettichschnidi rettichschnidi Awaiting requested review from rettichschnidi

@yonsch yonsch Awaiting requested review from yonsch

Assignees

@teburd teburd

Labels
area: DMA Direct Memory Access platform: Silabs Silicon Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Martinhoff-maker @teburd @jhedberg @jerome-pouiller @asmellby @kartben @zephyrbot