twister: testplan: do not error on missing unsatisfied env #82365
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsim requires a special setup for it to be usuable and run by twister. If this environment is not available, we should not error. Most developers and users of twister will not have the babblesim setup and reporting errors is misleading and confusing. So if such env. is not available, just filter as usual and do not error. Signed-off-by: Anas Nashif <[email protected]>
zephyrbot
requested review from
gchwier,
golowanow,
hakehuang,
KamilxPaszkiet,
LukaszMrugala and
PerMac
golowanow
reviewed
Nov 30, 2024
| @@ -71,6 +71,8 @@ class Filters: | |||
| TOOLCHAIN = 'Toolchain filter' | |||
| # in case an optional module is not available | |||
| MODULE = 'Module filter' | |||
| # in case an optional module is not available | |||
There was a problem hiding this comment.
Suggested change
| # in case an optional module is not available | |
| # in case of missing env. variable required for a platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bsim requires a special setup for it to be usuable and run by twister.
If this environment is not available, we should not error.
Most developers and users of twister will not have the babblesim setup
and reporting errors is misleading and confusing. So if such env. is not
available, just filter as usual and do not error.
Signed-off-by: Anas Nashif [email protected]