drivers: intel_adsp: Refactor Power Management Initialization for DMIC, SSP, and GPDMA Drivers #82115
+133
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmleman
requested review from
dcpleung,
teburd,
abonislawski,
marcinszkudlinski and
kv2019i
as code owners
zephyrbot
added
area: Xtensa
zephyrbot
requested review from
andyross,
ceolin,
iuliana-prodan,
juimonen,
jxstelter,
LaurentiuM1234,
lgirdwood,
lyakh,
nashif and
softwarecki
danieldegrasse
added a commit
to nxp-upstream/zephyr
that referenced
this pull request
Nov 27, 2024
When reprinting the shell command buffer with long user inputs, the reprinted buffer may cross a line boundary, and require a newline to be printed. For these cases, print the command buffer character by character, inserting newlines as appropriate. Fixes zephyrproject-rtos#82115 Signed-off-by: Daniel DeGrasse <[email protected]>
tmleman
force-pushed
the
topic/upstream/pr/pm/device_runtime/refactor
branch
from
e247afe to
b18d544
Compare
kv2019i
previously approved these changes
Nov 28, 2024
|
|
||
| return pm_device_runtime_enable(dev); | ||
| return pm_device_driver_init(dev, dmic_pm_action); |
There was a problem hiding this comment.
Not an expert with the pm code, but this does look very clean and matches with other drivers' use of Zephyr runtime-pm, so looks good for me.
tmleman
force-pushed
the
topic/upstream/pr/pm/device_runtime/refactor
branch
3 times, most recently
from
136207d to
b5e455c
Compare
|
Rebase to enable testing in SOF CI: thesofproject/sof#9713 |
This patch refactors the power management initialization for the DMIC driver across ACE15, ACE20, and ACE30 generations to align with the recommended practices outlined in the documentation. The changes include: 1. Replacing the conditional initialization of power management state with a call to `pm_device_driver_init` in the `dai_dmic_initialize_device` function. 2. Adding the `zephyr,pm-device-runtime-auto` property to the DMIC nodes in the device tree files for ACE15, ACE20, and ACE30. These changes ensure that the DMIC driver is initialized with the appropriate power management state and that runtime power management is automatically enabled based on the device tree configuration. The functionality of the power management state remains unchanged, ensuring consistent behavior. Signed-off-by: Tomasz Leman <[email protected]>
This patch refactors the power management initialization for the SSP driver across ACE15, ACE20, and ACE30 generations to align with the recommended practices outlined in the documentation. The changes include: 1. Replacing the conditional initialization of power management state with a call to `pm_device_driver_init` in the `ssp_init` function. 2. Adding the `zephyr,pm-device-runtime-auto` property to the SSP nodes in the device tree files for ACE15, ACE20, and ACE30. 3. Moving the power domain assignment for the SSP device in the device tree. The previous configuration resulted in the device not being under any power domain and being initialized as always ON. These changes ensure that the SSP driver is initialized with the appropriate power management state and that runtime power management is automatically enabled based on the device tree configuration. The functionality of the power management state remains unchanged, ensuring consistent behavior. Signed-off-by: Tomasz Leman <[email protected]>
This patch refactors the power management initialization for the Intel ADSP GPDMA driver. The changes include: 1. Replacing the conditional initialization of power management state with a call to `pm_device_driver_init` in the `intel_adsp_gpdma_init` function. 2. Ensuring that the GPDMA driver is initialized with the appropriate power management state and that runtime power management is automatically enabled based on the device tree configuration. These changes streamline the power management initialization process and ensure consistency with other drivers. Signed-off-by: Tomasz Leman <[email protected]>
|
SOF CI did not show any regression. |
serhiy-katsyuba-intel
approved these changes
Dec 11, 2024
LaurentiuM1234
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the power management initialization for the DMIC, SSP, and GPDMA drivers across ACE15, ACE20, and ACE30 generations.
The current implementation of power management initialization for these drivers does not fully comply with the recommended practices outlined in the documentation. This refactor addresses these issues, ensuring that the drivers are initialized correctly and consistently. The functionality of the power management state remains unchanged, ensuring consistent behavior across all three generations.
Changes: