Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth: Host: bsim compilation improvements #82058

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bluetooth: Host: bsim compilation improvements #82058

wants to merge 1 commit into from
+1,297 −944

Conversation

ardo-nordic
Copy link

@ardo-nordic ardo-nordic commented Nov 26, 2024 •
edited by jhedberg
Loading

  • All compile.sh files in bsim/host removed and replaced with testcase.yaml files which are used for building with twister
  • Some host tests which compile and run on bsim53 (net core) are enabled
  • Some conf files streamlined to avoid code duplication
  • CI bsim files updated correspondingly

Fixes #77055

@ardo-nordic ardo-nordic force-pushed the 77055_ble_host_bsim_comp_improvements branch 7 times, most recently from 800078b to 08b5104 Compare November 29, 2024 09:13
@ardo-nordic
tests: bsim: bluetooth: host: use twister to compile tests
8bdaa64 
Bluetooth host bsim tests are compiled with shell scripts, but it is
possible to use twister, which supports compilation (but not running
at the moment). Copiling with twister provides cleaner interface and
more flexible configuration.

Signed-off-by: Artur Dobrynin <[email protected]>
@ardo-nordic ardo-nordic force-pushed the 77055_ble_host_bsim_comp_improvements branch from 08b5104 to 8bdaa64 Compare November 29, 2024 14:09
@ardo-nordic ardo-nordic marked this pull request as ready for review November 29, 2024 14:40
@jhedberg jhedberg changed the title Issue #77055: ble host bsim compilation improvements Bluetooth: Host: bsim compilation improvements Nov 29, 2024
@Thalley
Copy link
Collaborator

Thalley commented Nov 29, 2024

Just out of curiosity, do you have an example of what the user should do now to manually test a specific test?

Previously I called the compile.sh and the ran one of the test scripts to run a specific test locally. What should a user to do accomplish the same with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aescolar aescolar Awaiting requested review from aescolar

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@hermabe hermabe Awaiting requested review from hermabe

@jhedberg jhedberg Awaiting requested review from jhedberg

@rugeGerritsen rugeGerritsen Awaiting requested review from rugeGerritsen

@sjanc sjanc Awaiting requested review from sjanc

@Thalley Thalley Awaiting requested review from Thalley

@theob-pro theob-pro Awaiting requested review from theob-pro

At least 2 approving reviews are required to merge this pull request.

Assignees

@jhedberg jhedberg

@alwa-nordic alwa-nordic

Labels
area: Bluetooth Host area: Bluetooth platform: nRF BSIM Nordic Semiconductors, nRF BabbleSim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bluetooth: Host: bsim: Ensure all tests have its own compile.sh
5 participants
@ardo-nordic @Thalley @jhedberg @zephyrbot @alwa-nordic