west: runners: bossac: Honor --erase flag #81894
Open
+64
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
carlescufi,
mbolivar-ampere,
pdgendt and
swinslow
pdgendt
reviewed
Nov 25, 2024
Will do. Also noticed the test failure, will work on fixing that up. |
petejohanson
force-pushed
the
runners/add-bossac-erase-flag
branch
2 times, most recently
from
64a62d3
to
393d98a
Compare
Added a note to the migration guide, fixed the existing tests, and added a new one for the |
Instead of unconditionally erasing the whole target, add support for using the common --erase flag. Signed-off-by: Peter Johanson <[email protected]>
petejohanson
force-pushed
the
runners/add-bossac-erase-flag
branch
from
393d98a
to
6edddd9
Compare
pdgendt
approved these changes
Nov 25, 2024
|
@nandojve should the bossac runner be under SAM in the maintaners file? |
fabiobaltieri
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of unconditionally erasing the whole target, add support for using the common --erase flag.
This tweak is needed to avoid the bossac runner from erasing the whole chip every time it's run, helping preserve things like settings stored to flash when using them on samd21, for example.