Add rt1180 i3c support #81855
Open
Add rt1180 i3c support #81855
+226
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Sensors
zephyrbot
requested review from
avisconti,
butok,
danieldegrasse,
decsny,
DerekSnell,
EmilioCBen,
jeppenodgaard,
MaureenHelm,
teburd,
tristan-google,
ubieda,
yperess and
yvanderv
samples/sensor/thermometer/boards/mimxrt1180_evk_mimxrt1189_cm33.overlay
Outdated
Show resolved
Hide resolved
| i3c-scl-hz = <DT_FREQ_M(4)>; | ||
| i3c-od-scl-hz = <DT_FREQ_K(1500)>; | ||
|
|
||
| p3t1755: p3t1755@4800000236152a0090 { |
There was a problem hiding this comment.
Just a question- should we be defining this as a shield? It seems like we might reuse this sensor for I3C enablement on a bunch of platforms, right?
There was a problem hiding this comment.
- The name "shield" wasn't defined by me. NXP release the P3T1755DP Arduino® Shield Evaluation Board officially on NXP web
- Yes, we can use this board on a bunch of platforms, if exist arduino interface and standalone I3C interface on nxp board.
There was a problem hiding this comment.
Makes sense. We don't need to do this as part of this PR, but we should consider defining this as a shield to simplify future enablement- especially because it is using the Arduino interface. Is the I3C bus on the RT1180 exposed on the same pins Arduino typically uses for I2C?
There was a problem hiding this comment.
Thank you for pointing out. I have added p3t1755dp_ard shield board and support shield board on RT1180 board.
lucien-nxp
force-pushed
the
add_rt1180_i3c_support
branch
3 times, most recently
from
1903bb1
to
516dc33
Compare
lucien-nxp
force-pushed
the
add_rt1180_i3c_support
branch
3 times, most recently
from
6c068af
to
4187e99
Compare
Add a shield for P3T1755DP-ARD modules. Support the shield on MIMXRT1180-EVK board. Signed-off-by: Lucien Zhao <[email protected]>
add i3c instances enable i3c clock under soc folder Signed-off-by: Lucien Zhao <[email protected]>
add i3c case to get i3c instance clock Signed-off-by: Lucien Zhao <[email protected]>
add the i3c2 pin setting set i3c2 instance as ok status Signed-off-by: Lucien Zhao <[email protected]>
add mimxrt1180-evk board support description add shield parameter description for RT1180 board Signed-off-by: Lucien Zhao <[email protected]>
lucien-nxp
force-pushed
the
add_rt1180_i3c_support
branch
from
4187e99
to
899b546
Compare
hakehuang
reviewed
Dec 2, 2024
| filter: dt_alias_exists("ambient-temp0") | ||
| extra_args: SHIELD=p3t1755dp_ard | ||
| platform_allow: | ||
| - mimxrt1180_evk/mimxrt1189/cm33 # p3t1755 |
There was a problem hiding this comment.
do not add this, you can update the original test scenario by using
extra_args: platform:mimxrt1180_evk/mimxrt1189/cm33:SHIELD=p3t1755dp_ard
|
test PASS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support p3t1755 shield board on thermometer sample case using i3c2 instance.