Add global HSFLL clock control device driver #81735
Open
+548
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note @ppelikan-nordic |
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nordic
DNM
|
I need the to update the frequencies to match the opaque |
bjarki-andreasen
force-pushed
the
nordic-global-hsfll
branch
from
cbea899
to
197adff
Compare
bjarki-andreasen
force-pushed
the
nordic-global-hsfll
branch
from
197adff
to
c71d0d0
Compare
bjarki-andreasen
requested review from
anangl and
nordic-krch
as code owners
zephyrbot
added
platform: nRF
zephyrbot
requested review from
hubertmis,
jaz1-nordic,
kartben,
kl-cruz,
krish2718,
magp-nordic,
masz-nordic,
nashif,
nika-nordic and
sachinthegreen
bjarki-andreasen
force-pushed
the
nordic-global-hsfll
branch
from
c71d0d0
to
49f2189
Compare
bjarki-andreasen
force-pushed
the
nordic-global-hsfll
branch
from
49f2189
to
6b3e913
Compare
bjarki-andreasen
force-pushed
the
nordic-global-hsfll
branch
from
6b3e913
to
05a3ac4
Compare
bjarki-andreasen
force-pushed
the
nordic-global-hsfll
branch
2 times, most recently
from
b3d56ce
to
de3678e
Compare
57300
reviewed
Dec 2, 2024
| 320000000>; | ||
| }; | ||
|
|
||
| compatible: "nordic,nrf-global-hsfll" |
There was a problem hiding this comment.
I suggest nordic,nrf-hsfll-global to align with other Nordic bindings. Maybe even rename the local domain HSFLL binding to nordic,nrf-hsfll-local.
There was a problem hiding this comment.
I would like to do that, what about renaming hsfll120: to hsfll_global: in the devicetree?
There was a problem hiding this comment.
It can stay as hsfll120 to match the datasheet.
There was a problem hiding this comment.
deal, and done
There was a problem hiding this comment.
Okay, you used nordic,nrf-local-hsfll instead?
There was a problem hiding this comment.
oh, sorry, did not notice the change of order :) will update
bjarki-andreasen
force-pushed
the
nordic-global-hsfll
branch
from
de3678e
to
4bebaa1
Compare
Update hal_nordic revision to include nrfs services: - GDPWR - GDFS Signed-off-by: Bjarki Arge Andreasen <[email protected]>
nRFs exposes now all power domains, following their actual name in the specification. Add support for all of them in the GPD service. Note that this is a breaking change: running this code requires a new SCFW as IDs have changed in nRFs and so SCFW. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Adding the implementation for the GDFS service Signed-off-by: Paweł Pelikan <[email protected]>
bjarki-andreasen
force-pushed
the
nordic-global-hsfll
branch
2 times, most recently
from
d8652b0
to
1674732
Compare
Add specific device model for global hsfll clock and update dts tree to use specific model. The clock is not fixed, and configurable at runtime to predefined frequencies specified by the platform. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
The nrf-hsfll was previously the only supported HSFLL clock, hence it was not namespaced fully. Since we added nrf-hsfll-global, we should add the namespace to nrf-hsfll as well. Updates drivers and devicetree uses of HSFLL as well. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Add device driver support for global hsfll clock. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Extend sample to support global hsfll clock control. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Extend test suite to test global HSFLL clock. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Introduce feature which restricts the minimum global hsfll frequency. This feature is selected by default to preserve the behavior of the global hsfll before the clock control driver for it was introduced, which configured it as a fixed clock at 320MHz. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
force-pushed
the
nordic-global-hsfll
branch
from
1674732
to
1d3ce03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now since testing is blocked by missing firmware for the nRF54H20