-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: silabs: add default uart-pipe options #81702
boards: silabs: add default uart-pipe options #81702
Conversation
Hello @kedMertens, and thank you very much for your first pull request to the Zephyr project! |
@kedMertens thanks! There seems to be a bunch of Compliance check failures - please fix those. |
Sorry about that, didn't setup pre hooks to check locally, I'm on it. |
ae20f94
to
4afc0a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a specialist of the Zephyr test system, but this PR looks good.
I believe this change is not sufficient to have |
Not sure, the tester app is meant to be used for running qualification tests with auto-pts framework. Do you mean that there is a CI job to build the app? |
Indeed. You need to add the platform to https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/bluetooth/tester/testcase.yaml if you want CI to build it |
The upstream CI policy is to never build any configuration that depends on binary blobs, and this board is such a configuration (the Silabs Bluetooth Link Layer is binary-only in a Zephyr context). Is there a risk that upstream CI might try to build this configuration if it's added? If yes, then it shouldn't be added there, rather there should just be a forced explicit platform selection in downstream CI. |
4afc0a5
to
4e403e9
Compare
4e403e9
to
4f43d0c
Compare
@kedMertens #79931 was merged, so you need to update all |
Add uart-pipe driver default option in device trees for silabs boards. It enables vcom for the boards, handy to have for sample application, for example tester app. Signed-off-by: Evgenii Kosenko <[email protected]>
Simple renaming is not enough. Tried against a known passing pts test and get:
Error -141 is mbedtls PSA_ERROR_INSUFFICIENT_MEMORY, most likely related to #82217 UPD: |
4f43d0c
to
bef99eb
Compare
Adds CONFIG_BT_SEND_ECC_EMULATION on silabs bluetooth boards. Signed-off-by: Evgenii Kosenko <[email protected]>
bef99eb
to
455b773
Compare
Hi @kedMertens! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
Adds overlay and config files to tester app for xg24_rb4187c silabs board. Overlay enables uart for BTP communication and config file enables RTT logging.Reworked the PR to enable for all silabs boards a default option for uart-pipe driver.
Added a Kconfig for tinycrypt ecc to be able to use SM features with xg24_rb4187c. There is an ongoing work that will provide a proper way to enable it for all boards #81776