drivers: esp32: update runtime heap usage #79523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
sylvioalves
force-pushed
the
improvement/runtime_heap
branch
4 times, most recently
from
9f382ad to
5c7a7a1
Compare
sylvioalves
force-pushed
the
improvement/runtime_heap
branch
3 times, most recently
from
b9c5237 to
2e52749
Compare
sylvioalves
requested review from
alwa-nordic,
jhedberg and
Vudentz
as code owners
sylvioalves
force-pushed
the
improvement/runtime_heap
branch
from
2e52749 to
a77c0c8
Compare
zephyrbot
added
platform: ESP32
zephyrbot
requested review from
hermabe,
HoZHel,
jukkar,
LucasTambor,
marekmatej,
raffarost,
rlubos and
sjanc
|
Depends on #79524 due to compliance check. |
jukkar
previously approved these changes
Oct 14, 2024
wmrsouza
previously approved these changes
Oct 14, 2024
jhedberg
previously approved these changes
Oct 14, 2024
uLipe
previously approved these changes
Oct 14, 2024
marekmatej
previously approved these changes
Oct 16, 2024
Update both Wi-FI and BLE init codes to return proper error code and logging when it is missing heap. Signed-off-by: Sylvio Alves <[email protected]>
This commit applies several changes in the way "heap_runtime" feature is used. It can't be split due to bisectability issues. Whenever the feature is enabled, a new heap is created and custom malloc/calloc/free functions are added into the build system. Those functions are currently used for internal Wi-Fi and BLE drivers only. Such changes are described below: 1) Rename heap.c to esp_heap_runtime.c for better readability. 2) Rename RUNTIME_HEAP to HEAP_RUNTIME to make it similar to what is available in Zephyr. 3) Add runtime heap to BT as such as Wi-Fi. Fixes zephyrproject-rtos#79490 Fixes zephyrproject-rtos#79470 Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves
dismissed stale reviews from marekmatej, uLipe, jhedberg, wmrsouza, and jukkar
via
49570fa
sylvioalves
force-pushed
the
improvement/runtime_heap
branch
from
a77c0c8 to
49570fa
Compare
|
Rebased, |
sylvioalves
requested review from
wmrsouza,
marekmatej,
jukkar,
jhedberg and
uLipe
jhedberg
approved these changes
Oct 16, 2024
wmrsouza
approved these changes
Oct 16, 2024
jukkar
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit applies several changes in the way "heap_runtime"
feature is used. It can't be split due to bisectabily issues.
Whenever the feature is enabled, a new heap is created and
custom malloc/calloc/free functions are added into the build
system. Those functions are currently used for internal Wi-Fi and BLE
drivers only.
Such changes are described below:
available in Zephyr.