Add RT700 basic environment support #79376

lucien-nxp · 2024-10-03T15:38:12Z

support gpio/uart function

zephyrbot · 2024-10-03T15:39:12Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_nxp	zephyrproject-rtos/hal_nxp@`c42d70d`	zephyrproject-rtos/hal_nxp#444	zephyrproject-rtos/hal_nxp#444/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

soc/nxp/common/Kconfig.flexspi_xip

soc/nxp/imxrt/Kconfig

soc/nxp/imxrt/imxrt7xx/Kconfig

danieldegrasse · 2024-10-03T19:35:57Z

boards/nxp/mimxrt700_evk/doc/index.rst

+high-performance numerical tasks such as audio and image processing and supports both fixed-point and
+floating-point operations.
+
+Note: Due to board isn't launched, the picture is blank


Maybe just don't include an image? I'm not aware of a requirement that we actually have one.

It was announced - maybe you can find a picture here: https://www.nxp.com/products/processors-and-microcontrollers/arm-microcontrollers/i-mx-rt-crossover-mcus/i-mx-rt700-crossover-mcu-with-arm-cortex-m33-npu-dsp-and-gpu-cores:i.MX-RT700

Only release RT700 soc, EVK board don't launch currently. We can't show the board picture currently.

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0.dts

boards/nxp/mimxrt700_evk/doc/index.rst

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu1_defconfig

boards/nxp/mimxrt700_evk/Kconfig.defconfig

boards/nxp/mimxrt700_evk/doc/mimxrt700_evk.webp

boards/nxp/mimxrt700_evk/mimxrt700_evk-pinctrl.dtsi

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0.dts

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0_defconfig

nordicjm · 2024-10-04T08:11:31Z

soc/nxp/imxrt/Kconfig

+config XSPI_CONFIG_BLOCK_OFFSET
+	hex "XSPI config block offset"
+	default 0x0
+	help
+	  XSPI configuration block consists of parameters regarding specific
+	  flash devices including read command sequence, quad mode enablement
+	  sequence (optional), etc. The boot ROM expects XSPI configuration
+	  parameter to be presented in serial nor flash.


why is this not in dts?

soc/nxp/imxrt/imxrt7xx/Kconfig.soc

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0.dts

lucien-nxp · 2024-11-15T06:00:48Z

I created new pinctrl driver(iopctl driver) for RT 3 digital platforms, it makes better service the multi iopctl instances on RT700, and keep a same pinctrl model for RT 3 digital platforms. So this PR is currently dependent on my other PR#81086. I will make sure my other PR merge as soon as possible after the freeze ends.

kartben · 2024-11-15T07:16:21Z

@lucien-nxp looks like there was a rebase accident :)

lucien-nxp · 2024-11-15T07:37:48Z

@lucien-nxp looks like there was a rebase accident :)
This PR is dependent on another #81086. I will speed another PR merged(when windows open), then rebase this PR the newest main node. Currently, only do ci test on this PR. Thank you.

DerekSnell

Hi @lucien-nxp ,
Thank you for addressing all my requests. I am removing my block. But I will let other reviewers address their requests and the IOPCTL changes. Thank you

My requests we addressed

Raymond0225 · 2024-11-04T22:32:01Z

drivers/pinctrl/pinctrl_lpc_iocon.c

 int pinctrl_configure_pins(const pinctrl_soc_pin_t *pins, uint8_t pin_cnt,
 			   uintptr_t reg)
 {
 	for (uint8_t i = 0; i < pin_cnt; i++) {
 		uint32_t pin_mux = pins[i];
+#if defined(CONFIG_SOC_SERIES_IMXRT7XX) && defined(CONFIG_SOC_FAMILY_NXP_IMXRT)
+		uint8_t port_no = PORT_NO(pin_mux);


Agree that we should come up with a better method to isolate these differences instead of use SOC macro definition directly. Just image if we have RT2xxx which as same IP, how to reuse it?

Raymond0225 · 2024-11-04T22:36:57Z

dts/arm/nxp/nxp_rt7xx_cm33_cpu1.dtsi

@@ -0,0 +1,353 @@
+/*


How about we define a common dtsi file which include all basic SOC device information. All no-shared devices are disabled by default. Then define seperate dtsi files for cpu0/cpu1 which based on this common file and only enable CPU0/1 dedicated devices on each file?

I think there is no need to create common dtsi for RT700, domain makes two core access IP instance is different.

Raymond0225 · 2024-11-18T19:42:22Z

boards/nxp/mimxrt700_evk/board.c

+	RESET_ClearPeripheralReset(kGPIO7_RST_SHIFT_RSTn);
+#endif
+
+#if DT_NODE_HAS_STATUS(DT_NODELABEL(gpio8), okay)


Here a lot of duplicate code, can we use DT_INST_FOREACH_STATUS_OKAY to simply it?

lucien-nxp · 2024-11-20T07:20:24Z

Hi @Raymond0225 ,
For Q1. Now iocon driver won't be used for RT 3 digital platforms. I have created new IOPCTL driver to service RT 3 digital platforms.
For Q3, How can I use DT_INST_FOREACH_STATUS_OKAY ? Use DT_INST_FOREACH_STATUS_OKAY need to match with macro DT_DRV_COMPAT, how can I handle multi kinds of IPs.

lucien-nxp · 2024-11-29T09:32:45Z

Hi @hakehuang ， Could you help test all the LPC and RT3 digitals platforms based on this PR? I have updated iocon driver and pin header file for RT700. Thank you.

hakehuang · 2024-12-02T06:22:09Z

Hi @hakehuang ， Could you help test all the LPC and RT3 digitals platforms based on this PR? I have updated iocon driver and pin header file for RT700. Thank you.

sure, I kick another round of testing, will feedback once done

@lucien-nxp

op 500 values of testsuite.keyword	Failed
tests/kernel/mem_protect/mem_protect/kernel.memory_protection	15
tests/kernel/mem_protect/userspace/kernel.memory_protection.userspace	1
tests/kernel/threads/thread_stack/kernel.threads.armv8m_mpu_stack_guard	1
tests/kernel/fatal/exception/kernel.common.stack_protection_armv8m_mpu_stack_guard	2
samples/userspace/prod_consumer/sample.userspace.prod_consumer	1
samples/userspace/shared_mem/sample.kernel.memory_protection.shared_mem	1

add rt7xx files related to soc support basic clock enablement add HAS_MCUX_XSPI/HAS_GLIKEY Kconfig add common/Kconfig.xspi_xip file Signed-off-by: Lucien Zhao <[email protected]>

add RT7xx dts files add iocon/gpio/flexcomm/clock instances in dts Signed-off-by: Lucien Zhao <[email protected]>

add nxp,imx-xspi-device.yaml add nxp,imx-xspi-mx25um51345g.yaml add nxp,imx-xspi.yaml Signed-off-by: Lucien Zhao <[email protected]>

add more flexcomm instances clock support to adapt rt700 instances number add xspi clock support Signed-off-by: Lucien Zhao <[email protected]>

Due to there is no port on RT7xx soc, update driver to adapt rt7xx pin mux model(Use IOPCTL_PinMuxSet function to configure pinmux set) Signed-off-by: Lucien Zhao <[email protected]>

update gpio driver to adapt rt7xx gpio model: 1. There is no PORT_Type on RT7xx,so set PORT_Type as void 2. Add port_no parameter in gpio_mcux_config to adapt IOPCTL driver 3. Add gpio-port-offest parameter in blinding, it will help map the relation between index n and gpio port when some soc have domain access attribution. 4. Add code to adapt RT700 GPIO attribute configuration Signed-off-by: Lucien Zhao <[email protected]>

add files related to mimxrt700_evk board add gpio/uart function support on board Signed-off-by: Lucien Zhao <[email protected]>

track rt700 sdk files update PR branch Signed-off-by: Lucien Zhao <[email protected]>

lucien-nxp requested review from mmahadevan108 and dleach02 as code owners October 3, 2024 15:38

zephyrbot added area: Clock Control area: GPIO platform: NXP NXP area: Pinctrl platform: NXP Drivers NXP Semiconductors, drivers labels Oct 3, 2024

zephyrbot requested review from butok, danieldegrasse, dbaluta, decsny, DerekSnell, EmilioCBen, gmarull, henrikbrixandersen, manuargue, MarkWangChinese, mnkp, nordic-krch and yvanderv October 3, 2024 15:39

zephyrbot assigned dleach02 and mmahadevan108 Oct 3, 2024

zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Oct 3, 2024

lucien-nxp force-pushed the add_rt700_baseline_support branch from aebb39a to a8fc58d Compare October 3, 2024 16:42

danieldegrasse reviewed Oct 3, 2024

View reviewed changes

nordicjm requested changes Oct 4, 2024

View reviewed changes

butok reviewed Oct 4, 2024

View reviewed changes

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_cpu0.dts Outdated Show resolved Hide resolved

lucien-nxp force-pushed the add_rt700_baseline_support branch from 37b37d8 to 86b38fc Compare November 15, 2024 02:23

zephyrbot added the Release Notes To be mentioned in the release notes label Nov 15, 2024

lucien-nxp force-pushed the add_rt700_baseline_support branch from 86b38fc to ac12049 Compare November 15, 2024 05:55

lucien-nxp requested review from ifyall and npal-cy as code owners November 15, 2024 05:55

lucien-nxp force-pushed the add_rt700_baseline_support branch from ac12049 to f225bbe Compare November 15, 2024 07:04

lucien-nxp closed this Nov 15, 2024

lucien-nxp reopened this Nov 15, 2024

lucien-nxp force-pushed the add_rt700_baseline_support branch from f225bbe to 252ce23 Compare November 18, 2024 03:06

DerekSnell reviewed Nov 18, 2024

View reviewed changes

Raymond0225 reviewed Nov 18, 2024

View reviewed changes

lucien-nxp force-pushed the add_rt700_baseline_support branch 2 times, most recently from 4e08e1a to 8190cc8 Compare November 29, 2024 09:26

lucien-nxp force-pushed the add_rt700_baseline_support branch from 8190cc8 to 2334439 Compare December 2, 2024 10:55

lucien-nxp added 8 commits December 3, 2024 10:59

soc: nxp: imxrt: imxrt7xx: add rt7xx soc files

cc979ba

add rt7xx files related to soc support basic clock enablement add HAS_MCUX_XSPI/HAS_GLIKEY Kconfig add common/Kconfig.xspi_xip file Signed-off-by: Lucien Zhao <[email protected]>

dts: arm: nxp: add RT7xx dts files

7c9132b

add RT7xx dts files add iocon/gpio/flexcomm/clock instances in dts Signed-off-by: Lucien Zhao <[email protected]>

dts: bindings: add the first version binding for nxp,imx-xspi IP

3829eb5

add nxp,imx-xspi-device.yaml add nxp,imx-xspi-mx25um51345g.yaml add nxp,imx-xspi.yaml Signed-off-by: Lucien Zhao <[email protected]>

drivers: clock_control: update mcux_lpc_syscon_clock.c drivers

9370334

add more flexcomm instances clock support to adapt rt700 instances number add xspi clock support Signed-off-by: Lucien Zhao <[email protected]>

drivers: pinctrl: update pinctrl_lpc_iocon.c driver

801e919

Due to there is no port on RT7xx soc, update driver to adapt rt7xx pin mux model(Use IOPCTL_PinMuxSet function to configure pinmux set) Signed-off-by: Lucien Zhao <[email protected]>

boards: nxp: add mimxrt700_evk board

fef9784

add files related to mimxrt700_evk board add gpio/uart function support on board Signed-off-by: Lucien Zhao <[email protected]>

manifest: update west.yml

59930f1

track rt700 sdk files update PR branch Signed-off-by: Lucien Zhao <[email protected]>

lucien-nxp force-pushed the add_rt700_baseline_support branch from 2334439 to 59930f1 Compare December 3, 2024 02:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add RT700 basic environment support #79376

Add RT700 basic environment support #79376

lucien-nxp commented Oct 3, 2024

zephyrbot commented Oct 3, 2024 •

edited

Loading

danieldegrasse Oct 3, 2024

iuliana-prodan Oct 4, 2024

lucien-nxp Oct 16, 2024

nordicjm Oct 4, 2024

lucien-nxp commented Nov 15, 2024 •

edited

Loading

kartben commented Nov 15, 2024

lucien-nxp commented Nov 15, 2024 •

edited

Loading

DerekSnell left a comment

Raymond0225 Nov 4, 2024

Raymond0225 Nov 4, 2024

lucien-nxp Nov 20, 2024

Raymond0225 Nov 18, 2024

lucien-nxp commented Nov 20, 2024 •

edited

Loading

lucien-nxp commented Nov 29, 2024

hakehuang commented Dec 2, 2024 •

edited

Loading

Add RT700 basic environment support #79376

Are you sure you want to change the base?

Add RT700 basic environment support #79376

Conversation

lucien-nxp commented Oct 3, 2024

zephyrbot commented Oct 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucien-nxp commented Nov 15, 2024 • edited Loading

kartben commented Nov 15, 2024

lucien-nxp commented Nov 15, 2024 • edited Loading

DerekSnell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucien-nxp commented Nov 20, 2024 • edited Loading

lucien-nxp commented Nov 29, 2024

hakehuang commented Dec 2, 2024 • edited Loading

zephyrbot commented Oct 3, 2024 •

edited

Loading

lucien-nxp commented Nov 15, 2024 •

edited

Loading

lucien-nxp commented Nov 15, 2024 •

edited

Loading

lucien-nxp commented Nov 20, 2024 •

edited

Loading

hakehuang commented Dec 2, 2024 •

edited

Loading