boards: nxp: Add Serial Recovery button alias #79374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes MCUBoot Serial Recovery compilation error "Serial recovery/USB DFU button must be declared in device tree as 'mcuboot_button0'" Signed-off-by: Andrej Butok <[email protected]>
zephyrbot
requested review from
danieldegrasse,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
mmahadevan108 and
yvanderv
danieldegrasse
approved these changes
Oct 3, 2024
decsny
approved these changes
Oct 4, 2024
| @@ -18,6 +18,7 @@ | |||
| sw1 = &user_button_2; | |||
| magn0 = &fxos8700; | |||
| accel0 = &fxos8700; | |||
| mcuboot-button0 = &user_button_3; | |||
There was a problem hiding this comment.
Just curious, how did you decide which button to use.
There was a problem hiding this comment.
Just curious, how did you decide which button to use.
All these boards have at least one button and it is sw0.
There was a problem hiding this comment.
Choosing the wrong button can cause this feature to not work at all. See e.g. #79715
Were these configurations tested?
dleach02
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MCUBoot Serial Recovery compilation error "Serial recovery/USB DFU button must be declared in device tree as 'mcuboot_button0'"