Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mcux lpuart async fixes #79325

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Mcux lpuart async fixes #79325

merged 2 commits into from
Oct 15, 2024

Conversation

hakehuang
Copy link
Collaborator

@hakehuang hakehuang commented Oct 2, 2024 •
edited
Loading

uart_async_api for NXP RT11xx series async testing failure, and after check the uart_mcux_lpuart.c, there are several issues found.
and the uart_async_api test need also some change to fit in DMA context.

fixes: #79323

@hakehuang hakehuang requested a review from EmilioCBen October 2, 2024 13:26
@zephyrbot zephyrbot added area: UART Universal Asynchronous Receiver-Transmitter platform: NXP Drivers NXP Semiconductors, drivers labels Oct 2, 2024
@hakehuang
Copy link
Collaborator Author

hakehuang commented Oct 2, 2024 •
edited
Loading

@EmilioCBen please help to review, this is a hidden issue after your fixes. Thanks.

test on mimxrt1170_evk/*/cm7

*** Booting Zephyr OS build v3.7.0-3804-g4d3f246abd65 ***
Running TESTSUITE uart_async_chain_read
===================================================================
E: No buffers to release from RX DMA!
E: No buffers to release from RX DMA!
START - test_chained_read
 PASS - test_chained_read in 0.426 seconds
===================================================================
TESTSUITE uart_async_chain_read succeeded
Running TESTSUITE uart_async_chain_write
===================================================================
E: No buffers to release from RX DMA!
START - test_chained_write
E: No buffers to release from RX DMA!
E: No buffers to release from RX DMA!
 PASS - test_chained_write in 0.009 seconds
===================================================================
TESTSUITE uart_async_chain_write succeeded
Running TESTSUITE uart_async_double_buf
===================================================================
E: No buffers to release from RX DMA!
START - test_double_buffer
 PASS - test_double_buffer in 3.397 seconds
===================================================================
TESTSUITE uart_async_double_buf succeeded
Running TESTSUITE uart_async_long_buf
===================================================================
E: No buffers to release from RX DMA!
START - test_long_buffers
 PASS - test_long_buffers in 0.162 seconds
===================================================================
TESTSUITE uart_async_long_buf succeeded
Running TESTSUITE uart_async_multi_rx
===================================================================
E: No buffers to release from RX DMA!
START - test_multiple_rx_enable
E: No buffers to release from RX DMA!
E: No buffers to release from RX DMA!
 PASS - test_multiple_rx_enable in 0.709 seconds
===================================================================
TESTSUITE uart_async_multi_rx succeeded
Running TESTSUITE uart_async_read_abort
===================================================================
E: No buffers to release from RX DMA!
START - test_read_abort
 PASS - test_read_abort in 1.120 seconds
===================================================================
TESTSUITE uart_async_read_abort succeeded
Running TESTSUITE uart_async_single_read
===================================================================
E: No buffers to release from RX DMA!
START - test_single_read
 PASS - test_single_read in 0.352 seconds
===================================================================
TESTSUITE uart_async_single_read succeeded
Running TESTSUITE uart_async_timeout
===================================================================
E: No buffers to release from RX DMA!
START - test_forever_timeout
E: No buffers to release from RX DMA!
E: No buffers to release from RX DMA!
 PASS - test_forever_timeout in 3.004 seconds
===================================================================
TESTSUITE uart_async_timeout succeeded
Running TESTSUITE uart_async_write_abort
===================================================================
E: No buffers to release from RX DMA!
START - test_write_abort
 PASS - test_write_abort in 0.102 seconds
===================================================================
TESTSUITE uart_async_write_abort succeeded

------ TESTSUITE SUMMARY START ------

SUITE PASS - 100.00% [uart_async_chain_read]: pass = 1, fail = 0, skip = 0, total = 1 duration = 0.426 seconds
 - PASS - [uart_async_chain_read.test_chained_read] duration = 0.426 seconds

SUITE PASS - 100.00% [uart_async_chain_write]: pass = 1, fail = 0, skip = 0, total = 1 duration = 0.009 seconds
 - PASS - [uart_async_chain_write.test_chained_write] duration = 0.009 seconds

SUITE PASS - 100.00% [uart_async_double_buf]: pass = 1, fail = 0, skip = 0, total = 1 duration = 3.397 seconds
 - PASS - [uart_async_double_buf.test_double_buffer] duration = 3.397 seconds

SUITE PASS - 100.00% [uart_async_long_buf]: pass = 1, fail = 0, skip = 0, total = 1 duration = 0.162 seconds
 - PASS - [uart_async_long_buf.test_long_buffers] duration = 0.162 seconds

SUITE PASS - 100.00% [uart_async_multi_rx]: pass = 1, fail = 0, skip = 0, total = 1 duration = 0.709 seconds
 - PASS - [uart_async_multi_rx.test_multiple_rx_enable] duration = 0.709 seconds

SUITE PASS - 100.00% [uart_async_read_abort]: pass = 1, fail = 0, skip = 0, total = 1 duration = 1.120 seconds
 - PASS - [uart_async_read_abort.test_read_abort] duration = 1.120 seconds

SUITE PASS - 100.00% [uart_async_single_read]: pass = 1, fail = 0, skip = 0, total = 1 duration = 0.352 seconds
 - PASS - [uart_async_single_read.test_single_read] duration = 0.352 seconds

SUITE PASS - 100.00% [uart_async_timeout]: pass = 1, fail = 0, skip = 0, total = 1 duration = 3.004 seconds
 - PASS - [uart_async_timeout.test_forever_timeout] duration = 3.004 seconds

SUITE PASS - 100.00% [uart_async_write_abort]: pass = 1, fail = 0, skip = 0, total = 1 duration = 0.102 seconds
 - PASS - [uart_async_write_abort.test_write_abort] duration = 0.102 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION SUCCESSFUL

@hakehuang hakehuang force-pushed the mcux_lpuart_async_fixes branch from 4d3f246 to 7152b13 Compare October 2, 2024 13:46
@hakehuang
driver: uart: uart_mcux_lpuart fix issues in async api
90b444c 
1. optimized the logic for buffer usage in async api
2. skip timeout flush when the remaining counts is 0,
   as this will trigger dma_callback to process.
3. remove scatter mode, as we are not using this mode
4. trigger after dma_reload.

Signed-off-by: Hake Huang <[email protected]>
@hakehuang hakehuang force-pushed the mcux_lpuart_async_fixes branch from 7152b13 to 882e865 Compare October 2, 2024 13:58
@hakehuang hakehuang requested a review from EmilioCBen October 10, 2024 10:59
@hakehuang
tests: uart_async_api: update test for dma usage
0e89fb7 
1. ensure the two dma buffers all aligned with 32 bits
2. clean the rx_data_idx at test begin

Signed-off-by: Hake Huang <[email protected]>
@hakehuang hakehuang force-pushed the mcux_lpuart_async_fixes branch 2 times, most recently from 5b78770 to 0e89fb7 Compare October 11, 2024 16:09
@hakehuang
Copy link
Collaborator Author

@mmahadevan108 , @EmilioCBen, @danieldegrasse can you help to review and kindly approve. Thanks

JarmouniA
JarmouniA reviewed Oct 15, 2024
View reviewed changes
tests/drivers/uart/uart_async_api/src/test_uart_async.c
/* To ensure 32-bit alignment of the buffer array,
* the two arrays are defined instead using an array of arrays
*/
static __aligned(32) uint8_t chained_read_buf_0[8] __used __NOCACHE;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question that's unrelated to your changes, does __used have any utility here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JarmouniA , __used is to force compiler to emit symbol, but I do not know whether it is a must in Zephyr, so I copy the line headless.

@nashif nashif merged commit 193bfab into zephyrproject-rtos:main Oct 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JarmouniA JarmouniA JarmouniA left review comments

@EmilioCBen EmilioCBen EmilioCBen approved these changes

@dleach02 dleach02 dleach02 approved these changes

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@dbaluta dbaluta Awaiting requested review from dbaluta

@dcpleung dcpleung Awaiting requested review from dcpleung

@decsny decsny Awaiting requested review from decsny

@manuargue manuargue Awaiting requested review from manuargue

@MarkWangChinese MarkWangChinese Awaiting requested review from MarkWangChinese

Assignees

@dleach02 dleach02

@dcpleung dcpleung

Labels
area: UART Universal Asynchronous Receiver-Transmitter platform: NXP Drivers NXP Semiconductors, drivers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests: uart: uart_async_api: test failure on mimxrt1170/1160 /1180
7 participants
@hakehuang @dleach02 @JarmouniA @EmilioCBen @nashif @zephyrbot @dcpleung