susbys/dfu/img_util: support ERASE PROGRESSIVELY for non-flash mem #79152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvlsianpu
added a commit
to nvlsianpu/fw-nrfconnect-zephyr
that referenced
this pull request
Sep 28, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
de-nordic
previously approved these changes
Sep 28, 2024
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 28, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
commented
Sep 29, 2024
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 30, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 30, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 1, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 1, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 1, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 1, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
rado17
pushed a commit
to rado17/sdk-zephyr
that referenced
this pull request
Oct 7, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
added a commit
to nvlsianpu/fw-nrfconnect-zephyr
that referenced
this pull request
Oct 7, 2024
…mentation Moved MCUboot trailer's status erase ahead any write operation. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
force-pushed
the
u_flash_img_flatten
branch
from
f21eb74 to
8314f7f
Compare
de-nordic
reviewed
Oct 8, 2024
subsys/dfu/img_util/flash_img.c
Outdated
| */ | ||
| offset = (toff + fparams->write_block_size - 1) & | ||
| ~(fparams->write_block_size - 1); | ||
| /* No alignment correction neede here, offset is corrected already */ |
There was a problem hiding this comment.
'and size should be aligned'
|
Please squash both commits together. |
nvlsianpu
force-pushed
the
u_flash_img_flatten
branch
from
8314f7f to
cb4cd12
Compare
nvlsianpu
added a commit
to nvlsianpu/fw-nrfconnect-zephyr
that referenced
this pull request
Oct 8, 2024
…mentation Moved MCUboot trailer's status erase ahead any write operation, which is step which helps with addition of support for devices don't require explicit pager erase. For these kind of devices flattening of mcuboot image status in the trailer was introduced. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
force-pushed
the
u_flash_img_flatten
branch
from
cb4cd12 to
1c63254
Compare
nvlsianpu
added a commit
to nvlsianpu/fw-nrfconnect-zephyr
that referenced
this pull request
Oct 8, 2024
…mentation Moved MCUboot trailer's status erase ahead any write operation, which is step which helps with addition of support for devices don't require explicit pager erase. For these kind of devices flattening of mcuboot image status in the trailer was introduced. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
added a commit
to nvlsianpu/fw-nrfconnect-zephyr
that referenced
this pull request
Oct 8, 2024
…mentation Moved MCUboot trailer's status erase ahead any write operation, which is step which helps with addition of support for devices don't require explicit pager erase. For these kind of devices flattening of mcuboot image status in the trailer was introduced. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
de-nordic
previously approved these changes
Oct 9, 2024
nordicjm
reviewed
Oct 10, 2024
subsys/dfu/img_util/flash_img.c
Outdated
| } else | ||
| #endif | ||
| { | ||
|
|
nordicjm
reviewed
Oct 10, 2024
subsys/dfu/img_util/flash_img.c
Outdated
| */ | ||
| offset = (toff + fparams->write_block_size - 1) & | ||
| ~(fparams->write_block_size - 1); | ||
| /* No alignment correction neede here, offset is corrected already |
There was a problem hiding this comment.
Suggested change
| /* No alignment correction neede here, offset is corrected already | |
| /* No alignment correction needed here, offset is corrected already |
nordicjm
reviewed
Oct 10, 2024
subsys/dfu/img_util/flash_img.c
Outdated
| int flash_img_buffered_write(struct flash_img_context *ctx, const uint8_t *data, | ||
| size_t len, bool flush) | ||
| { | ||
| int rc; | ||
|
|
||
| rc = stream_flash_buffered_write(&ctx->stream, data, len, flush); | ||
| if (!flush) { | ||
| /* If there is need to erase trailer, that should happen before any |
There was a problem hiding this comment.
Suggested change
| /* If there is need to erase trailer, that should happen before any | |
| /* If there is a need to erase the trailer, that should happen before any |
nvlsianpu
added a commit
to nvlsianpu/fw-nrfconnect-zephyr
that referenced
this pull request
Oct 10, 2024
…mentation Moved MCUboot trailer's status erase ahead any write operation, which is step which helps with addition of support for devices don't require explicit pager erase. For these kind of devices flattening of mcuboot image status in the trailer was introduced. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
added a commit
to nvlsianpu/fw-nrfconnect-zephyr
that referenced
this pull request
Oct 11, 2024
…mentation Moved MCUboot trailer's status erase ahead any write operation, which is step which helps with addition of support for devices don't require explicit pager erase. For these kind of devices flattening of mcuboot image status in the trailer was introduced. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
added a commit
to nvlsianpu/fw-nrfconnect-zephyr
that referenced
this pull request
Oct 14, 2024
…mentation Moved MCUboot trailer's status erase ahead any write operation, which is step which helps with addition of support for devices don't require explicit pager erase. For these kind of devices flattening of mcuboot image status in the trailer was introduced. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
force-pushed
the
u_flash_img_flatten
branch
from
1c63254 to
95198b1
Compare
nvlsianpu
added a commit
to nvlsianpu/fw-nrfconnect-zephyr
that referenced
this pull request
Oct 17, 2024
…mentation Moved MCUboot trailer's status erase ahead any write operation, which is step which helps with addition of support for devices don't require explicit pager erase. For these kind of devices flattening of mcuboot image status in the trailer was introduced. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
added a commit
to nvlsianpu/fw-nrfconnect-zephyr
that referenced
this pull request
Oct 17, 2024
…mentation Moved MCUboot trailer's status erase ahead any write operation, which is step which helps with addition of support for devices don't require explicit pager erase. For these kind of devices flattening of mcuboot image status in the trailer was introduced. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
Moved MCUboot trailer's status erase ahead any write operation, which is step which helps with addition of support for devices don't require explicit pager erase. For these kind of devices flattening of mcuboot image status in the trailer was introduced. Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
force-pushed
the
u_flash_img_flatten
branch
from
95198b1 to
32eab50
Compare
nvlsianpu
added a commit
to nvlsianpu/fw-nrfconnect-zephyr
that referenced
this pull request
Oct 17, 2024
…mentation Moved MCUboot trailer's status erase ahead any write operation, which is step which helps with addition of support for devices don't require explicit pager erase. For these kind of devices flattening of mcuboot image status in the trailer was introduced. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
added a commit
to nvlsianpu/fw-nrfconnect-zephyr
that referenced
this pull request
Oct 17, 2024
…mentation Moved MCUboot trailer's status erase ahead any write operation, which is step which helps with addition of support for devices don't require explicit pager erase. For these kind of devices flattening of mcuboot image status in the trailer was introduced. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
added a commit
to nvlsianpu/fw-nrfconnect-zephyr
that referenced
this pull request
Oct 17, 2024
…mentation Moved MCUboot trailer's status erase ahead any write operation, which is step which helps with addition of support for devices don't require explicit pager erase. For these kind of devices flattening of mcuboot image status in the trailer was introduced. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
nordicjm
approved these changes
Oct 18, 2024
de-nordic
approved these changes
Oct 18, 2024
nvlsianpu
added a commit
to nvlsianpu/fw-nrfconnect-zephyr
that referenced
this pull request
Oct 19, 2024
…mentation Moved MCUboot trailer's status erase ahead any write operation, which is step which helps with addition of support for devices don't require explicit pager erase. For these kind of devices flattening of mcuboot image status in the trailer was introduced. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]> (cherry picked from commit 30f066a)
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]> (cherry picked from commit 30f066a)
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
…on-flash mem Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant. Upstream PR: zephyrproject-rtos/zephyr#79152 Signed-off-by: Andrzej Puzdrowski <[email protected]> (cherry picked from commit 30f066a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for devices don't require explicit pager erase. For these device flattening of mcuboot image status is relevant.