Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: others: add esp32c3_supermini board support #78718

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rlneumiller
Copy link
Contributor

Adding the board under vendor "others" having been unable to determine
the original board designer\vendor with any confidence

Tested samples:
hello_world
basic/blinky

Signed-off-by: <Arrel Neumiller [email protected]>

sylvioalves
sylvioalves previously approved these changes Sep 19, 2024
kartben
kartben previously approved these changes Sep 19, 2024
sylvioalves
sylvioalves previously approved these changes Sep 20, 2024
Copy link

@marekmatej marekmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the vendor and copyright messages, LGTM

boards/others/esp32c3_supermini/Kconfig.defconfig Outdated Show resolved Hide resolved
boards/others/esp32c3_supermini/Kconfig.defconfig Outdated Show resolved Hide resolved
boards/others/esp32c3_supermini/board.yml Outdated Show resolved Hide resolved
boards/others/esp32c3_supermini/esp32c3_supermini.yaml Outdated Show resolved Hide resolved
@marekmatej
Copy link

Forget to ask for the board picture in the review :)

@marekmatej
Copy link

Please rephrase your commit message to have a general description of adding the new board. The message you put is more suitable for the PR description.

@rlneumiller rlneumiller force-pushed the add_board_esp32c3_supermini branch 2 times, most recently from fb6ae1b to e4a0fc1 Compare November 30, 2024 11:10
kartben
kartben previously approved these changes Nov 30, 2024
Add support for ESP32-C3 Super Mini board

Signed-off-by: Arrel Neumiller <[email protected]>
Copy link
Collaborator

@sylvioalves sylvioalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rlneumiller thanks for submitting again 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants