boards: rd_rw612_bga: Rename LED to "virtual"

[decsny]

There is not a real LED on this board, it's just a pin header, rename the led node to prevent confusion from green_led to virtual_led.

[danieldegrasse]

Looks like this is blocked by #78415

[mmahadevan108]

@decsny , can you take a look at the CI failures.

[decsny]

@decsny , can you take a look at the CI failures.

as daniel mentioned, it's the issue being fixed in #78415 and reported in #78649

[mmahadevan108]

@decsny Need a rebase?

[henrikbrixandersen]

If no LED is present on the board, why even have this node?

[dleach02]

If no LED is present on the board, why even have this node?

So blinky can still be built and run on the board with a test fixture to the pin header to verify operation.

[henrikbrixandersen]

So blinky can still be built and run on the board with a test fixture to the pin header to verify operation.

Blinky is a sample, not a test. GPIOs should be tested with the tests/drivers/gpio test suites. Including a "virtual" LED for being able to blink a non-existing LED provides no value, but can greatly confuse end-users (is there an LED? Isn't there an LED? Is this how I configure non-LED GPIOs in the devicetree?).

[decsny]

So blinky can still be built and run on the board with a test fixture to the pin header to verify operation.

Blinky is a sample, not a test. GPIOs should be tested with the tests/drivers/gpio test suites. Including a "virtual" LED for being able to blink a non-existing LED provides no value, but can greatly confuse end-users (is there an LED? Isn't there an LED? Is this how I configure non-LED GPIOs in the devicetree?).

yes, blinky is not useful to test GPIO rigorously from a true validation perspective of people maintaining the gpio drivers on the OS side or an upstream board. That's not the goal of this definition ...

We provided this definition of the "led" for convenience, as sometimes our customers just want a sample that toggles a GPIO, and blinky does that, LED on the board or not.

[decsny]

@henrikbrixandersen at the very least, what is currently in tree makes less sense as there is definitely no green LED, so what is your actual change request

[henrikbrixandersen]

@henrikbrixandersen at the very least, what is currently in tree makes less sense as there is definitely no green LED, so what is your actual change request

I suggest removing the fake LED altogether.

[decsny]

@henrikbrixandersen after lengthy and impassioned internal discussion, I confirmed we can remove the fake LED from the board definition.

[henrikbrixandersen]

@henrikbrixandersen after lengthy and impassioned internal discussion, I confirmed we can remove the fake LED from the board definition.

I am sorry to have caused this, but I am happy with your decision.