New board nucleo g431kb #78091

nagelkl · 2024-09-06T10:47:46Z

Added support for the ST Microelectronics nucleo g431kb board

The board port supports GPIO, PWM, the console and an i2c interface

github-actions · 2024-09-06T10:48:22Z

Hello @nagelkl, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

boards/st/nucleo_g431kb/doc/img/nucleo_g431kb.jpg

boards/st/nucleo_g431kb/doc/index.rst

boards/st/nucleo_g431kb/nucleo_g431kb.dts

boards/st/nucleo_g431kb/nucleo_g431kb_defconfig

nordicjm

also squash to 1 commit

nordicjm · 2024-09-12T07:49:52Z

also build error needs looking at and resolving

erwango · 2024-09-20T06:42:15Z

boards/st/nucleo_g431kb/nucleo_g431kb.dts

+stm32_lp_tick_source: &lptim1 {
+	clocks = <&rcc STM32_CLOCK_BUS_APB1 0x80000000>,
+			 <&rcc STM32_SRC_LSE LPTIM1_SEL(3)>;
+	status = "okay";
+};


You're declaring LSE as LPTIM source clock but it is not enabled.
Do you actually need LPTIM (used for power mgmt).

No, actually i don't neet power management, i will remove it

When i delete the &lptim1 from the dts- file all tested samples build without error and run fine but all twister tests in tests/lib/cpp/cxx fail due to a warning:
Kconfig for LPTIM source clock (LSE/LSE) is deprecated, use device tree.

I found that in the final generated .config file there is the line
CONFIG_STM32_LPTIM_TIMER=y
and
CONFIG_STM32_LPTIM_CLOCK_LSI=y

even if i delete the &lptim1 part from the dts- file.
I can not find where or how this Config Property gets set for the testsuite in tests/lib/cpp/cxx.
Am I missing something here?

The test case in question enables CONFIG_PM unconditionally, but on STM32 targets (from series which supports PM such as G4) a specific low power ticker configuration is required, which should be provided by lptim.

So, given this test configuration, you actually can't spare the following PM config:

&clk_lse { status = "okay"; }; stm32_lp_tick_source: &lptim1 { clocks = <&rcc STM32_CLOCK_BUS_APB1 0x80000000>, <&rcc STM32_SRC_LSE LPTIM1_SEL(3)>; status = "okay"; };

So for the PR i have to enable the lptim1 again in the Device Tree? Or should the test be changed? As i understand the purpose of the testcase is to check the different library configurations, why is there a dependency to power management?

boards/st/nucleo_g431kb/nucleo_g431kb_defconfig

boards/st/nucleo_g431kb/nucleo_g431kb.dts

boards/st/nucleo_g431kb/nucleo_g431kb.yaml

erwango

@JarmouniA PTAL

FRASTM · 2024-10-11T07:24:52Z

to fix the CI failure, add the clock domain definition for the lptim, in the board DTS, with LSI as clock source for the LPTIM. The nucleo32 board has no LSE clock.

stm32_lp_tick_source: &lptim1 {
	clocks = <&rcc STM32_CLOCK_BUS_APB1 0x80000000>,
		<&rcc STM32_SRC_LSI LPTIM1_SEL(1)>;
};

boards/st/nucleo_g431kb/board.yml

kartben

Did a more thorough review of the docs, sorry I didn't do this the first time around

kartben · 2024-10-11T18:54:15Z

boards/st/nucleo_g431kb/doc/index.rst

+Overview
+********
+
+The Nucleo G431kB board features an ARM Cortex-M4 based STM32G431kB MCU


Maybe a spell checker played tricks on you? Just noticed this sorry

Suggested change

The Nucleo G431kB board features an ARM Cortex-M4 based STM32G431kB MCU

The Nucleo G431KB board features an ARM Cortex-M4 based STM32G431KB MCU

The port started with a copy from the Nucleo G431RB board and some find and replace actions

kartben · 2024-10-11T18:54:27Z

boards/st/nucleo_g431kb/doc/index.rst

+Here are some highlights of the Nucleo G431kB board:
+
+- STM32 microcontroller in LQFP32 package
+- Arduino nano V3 connectivity


Suggested change

- Arduino nano V3 connectivity

- Arduino Nano V3 connectivity

kartben · 2024-10-11T18:54:57Z

boards/st/nucleo_g431kb/doc/index.rst

+- On-board ST-LINK/V3E debugger/programmer
+- Flexible board power supply:
+
+  - USB VBUS or external source(3.3V, 5V, 7 - 12V)


Suggested change

- USB VBUS or external source(3.3V, 5V, 7 - 12V)

- USB VBUS or external source(3.3 V, 5 V, 7-12 V)

kartben · 2024-10-11T18:56:44Z

boards/st/nucleo_g431kb/doc/index.rst

+
+More information about the board can be found at the `Nucleo G431KB website`_.
+
+- Development support: serial wire debug (SWD), JTAG, Embedded Trace Macrocell*


Assuming this is a copy-paste from somewhere, the asterisk probably doesn't make sense here?

Suggested change

- Development support: serial wire debug (SWD), JTAG, Embedded Trace Macrocell*

- Development support: serial wire debug (SWD), JTAG, Embedded Trace Macrocell.

kartben · 2024-10-11T18:56:59Z

boards/st/nucleo_g431kb/doc/index.rst

+
+- Development support: serial wire debug (SWD), JTAG, Embedded Trace Macrocell*
+
+More information about STM32G431RB can be found here:


Suggested change

More information about STM32G431RB can be found here:

More information about STM32G431KB can be found here:

kartben · 2024-10-11T18:57:38Z

boards/st/nucleo_g431kb/doc/index.rst

+High Speed oscillator is supported. By default System clock is driven by PLL clock at 170MHz,
+the PLL is driven by the 16MHz high speed internal oscillator.


Suggested change

High Speed oscillator is supported. By default System clock is driven by PLL clock at 170MHz,

the PLL is driven by the 16MHz high speed internal oscillator.

High Speed oscillator is supported. By default System clock is driven by PLL clock at 170 MHz,

the PLL is driven by the 16 MHz high speed internal oscillator.

kartben · 2024-10-11T18:58:17Z

boards/st/nucleo_g431kb/doc/index.rst

+Flashing an application to Nucleo G431kB
+----------------------------------------
+
+Connect the Nucleo G431kB to your host computer using the USB port,


Suggested change

Flashing an application to Nucleo G431kB

----------------------------------------

Connect the Nucleo G431kB to your host computer using the USB port,

Flashing an application to Nucleo G431KB

----------------------------------------

Connect the Nucleo G431KB to your host computer using the USB port,

kartben · 2024-10-11T18:58:42Z

boards/st/nucleo_g431kb/doc/index.rst

+
+.. zephyr-app-commands::
+   :zephyr-app: samples/hello_world
+   :board: nucleo_g431rb


Suggested change

:board: nucleo_g431rb

:board: nucleo_g431kb

boards/st/nucleo_g431kb/doc/index.rst

Add support for the nucleo g431kb Board. Signed-off-by: Klaus Nagel <[email protected]>

kartben

+1 for docs, thx!

erwango

Thanks for your patience in making all the changes that have been requested.
Approved

github-actions · 2024-10-15T11:54:37Z

Hi @nagelkl!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

zephyrbot added the platform: STM32 ST Micro STM32 label Sep 6, 2024

zephyrbot requested review from erwango, FRASTM, gautierg-st, GeorgeCGV, marwaiehm-st and mathieuchopstm September 6, 2024 10:48

zephyrbot assigned erwango Sep 6, 2024

nagelkl mentioned this pull request Sep 6, 2024

add support for the stm32 nucleo_g431kb board nagelkl/zephyr#1

Closed

nordicjm requested changes Sep 6, 2024

View reviewed changes

nordicjm reviewed Sep 6, 2024

View reviewed changes

nagelkl force-pushed the new_board_nucleo_g431kb branch from 7230571 to b1e8d85 Compare September 10, 2024 06:58

nagelkl requested a review from nordicjm September 10, 2024 07:00

nagelkl force-pushed the new_board_nucleo_g431kb branch 2 times, most recently from 9208b39 to d2e90d0 Compare September 16, 2024 07:35

nagelkl requested review from dcpleung, mmahadevan108, dleach02, anangl, sylvioalves, yonsch, manuargue, ssekar15, MulinChao, ChiHuaL, carlescufi, JiafeiPan and mniestroj as code owners September 16, 2024 07:35

nagelkl force-pushed the new_board_nucleo_g431kb branch from 738ff49 to 618fda0 Compare September 19, 2024 18:27

nagelkl requested a review from JarmouniA September 20, 2024 05:18

erwango requested changes Sep 20, 2024

View reviewed changes

jukkar removed request for jukkar and JarmouniA September 20, 2024 07:13

JarmouniA suggested changes Sep 20, 2024

View reviewed changes

boards/st/nucleo_g431kb/nucleo_g431kb.yaml Show resolved Hide resolved

nagelkl force-pushed the new_board_nucleo_g431kb branch from 618fda0 to 1f6b18e Compare October 9, 2024 17:05

erwango previously approved these changes Oct 10, 2024

View reviewed changes

nordicjm previously approved these changes Oct 10, 2024

View reviewed changes

nagelkl dismissed stale reviews from nordicjm and erwango via 955dbda October 11, 2024 12:24

nagelkl force-pushed the new_board_nucleo_g431kb branch from 1f6b18e to 955dbda Compare October 11, 2024 12:24

nagelkl requested review from erwango, JarmouniA and nordicjm October 11, 2024 13:54

kartben requested changes Oct 11, 2024

View reviewed changes

boards/st/nucleo_g431kb/board.yml Show resolved Hide resolved

nagelkl force-pushed the new_board_nucleo_g431kb branch from 955dbda to a6cf9f1 Compare October 11, 2024 16:56

nagelkl requested a review from kartben October 11, 2024 18:08

JarmouniA approved these changes Oct 11, 2024

View reviewed changes

kartben requested changes Oct 11, 2024

View reviewed changes

JarmouniA suggested changes Oct 11, 2024

View reviewed changes

boards/st/nucleo_g431kb/doc/index.rst Outdated Show resolved Hide resolved

boards/st/nucleo_g431kb/doc/index.rst Outdated Show resolved Hide resolved

boards/st/nucleo_g431kb/doc/index.rst Outdated Show resolved Hide resolved

boards: st: nucleo_g431kb: add support for nucleo g431kb

72d68ad

Add support for the nucleo g431kb Board. Signed-off-by: Klaus Nagel <[email protected]>

nagelkl force-pushed the new_board_nucleo_g431kb branch from a6cf9f1 to 72d68ad Compare October 11, 2024 21:12

JarmouniA approved these changes Oct 11, 2024

View reviewed changes

nagelkl requested a review from kartben October 12, 2024 06:13

kartben approved these changes Oct 15, 2024

View reviewed changes

erwango approved these changes Oct 15, 2024

View reviewed changes

carlescufi merged commit 03959a2 into zephyrproject-rtos:main Oct 15, 2024
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New board nucleo g431kb #78091

New board nucleo g431kb #78091

nagelkl commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

nordicjm left a comment

nordicjm commented Sep 12, 2024

erwango Sep 20, 2024

nagelkl Sep 20, 2024

nagelkl Oct 10, 2024

erwango Oct 11, 2024

nagelkl Oct 11, 2024

erwango left a comment

FRASTM commented Oct 11, 2024 •

edited

Loading

kartben left a comment

kartben Oct 11, 2024

nagelkl Oct 11, 2024

kartben Oct 11, 2024

kartben Oct 11, 2024

kartben Oct 11, 2024

kartben Oct 11, 2024

kartben Oct 11, 2024

kartben Oct 11, 2024

kartben Oct 11, 2024

kartben left a comment

erwango left a comment

github-actions bot commented Oct 15, 2024

	The Nucleo G431kB board features an ARM Cortex-M4 based STM32G431kB MCU
	The Nucleo G431KB board features an ARM Cortex-M4 based STM32G431KB MCU

	- Arduino nano V3 connectivity
	- Arduino Nano V3 connectivity

	- USB VBUS or external source(3.3V, 5V, 7 - 12V)
	- USB VBUS or external source(3.3 V, 5 V, 7-12 V)


		More information about the board can be found at the `Nucleo G431KB website`_.

		- Development support: serial wire debug (SWD), JTAG, Embedded Trace Macrocell*


		- Development support: serial wire debug (SWD), JTAG, Embedded Trace Macrocell*

		More information about STM32G431RB can be found here:

	More information about STM32G431RB can be found here:
	More information about STM32G431KB can be found here:

		High Speed oscillator is supported. By default System clock is driven by PLL clock at 170MHz,
		the PLL is driven by the 16MHz high speed internal oscillator.

New board nucleo g431kb #78091

New board nucleo g431kb #78091

Conversation

nagelkl commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

nordicjm left a comment

Choose a reason for hiding this comment

nordicjm commented Sep 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erwango left a comment

Choose a reason for hiding this comment

FRASTM commented Oct 11, 2024 • edited Loading

kartben left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kartben left a comment

Choose a reason for hiding this comment

erwango left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 15, 2024

FRASTM commented Oct 11, 2024 •

edited

Loading