[Backport v3.5-branch] net: mqtt: Fix possible socket leak with websocket transport #75505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case underlying TCP/TLS connection is already down, the websocket_disconnect() call is expected to fail, as it involves communication. Therefore, mqtt_client_websocket_disconnect() should not quit early in such cases, as it could lead to an underlying socket leak. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 4625fa7)
henrikbrixandersen
approved these changes
Jul 5, 2024
rlubos
approved these changes
Jul 5, 2024
fabiobaltieri
approved these changes
Jul 5, 2024
jhedberg
approved these changes
Jul 5, 2024
jukkar
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 4625fa7 from #75363.
Fixes: #75334