-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake/compiler/gcc: use -flto/-fno-lto only for gcc >= 4.5.0 #69058
Merged
henrikbrixandersen
merged 1 commit into
zephyrproject-rtos:main
from
marc-hb:fto-gcc-450
Feb 16, 2024
Merged
cmake/compiler/gcc: use -flto/-fno-lto only for gcc >= 4.5.0 #69058
henrikbrixandersen
merged 1 commit into
zephyrproject-rtos:main
from
marc-hb:fto-gcc-450
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes commit 26c8776 ("buildsystem: Add an option to enable LTO") Fixes the following error when compiling offsets.c xt-xcc ERROR parsing -fno-lto: unknown flag LTO options were introduced in gcc 4.5.0, compare: https://gcc.gnu.org/onlinedocs/gcc-4.4.6/gcc/Option-Summary.html https://gcc.gnu.org/onlinedocs/gcc-4.5.0/gcc/Option-Summary.html Signed-off-by: Marc Herbert <[email protected]>
marc-hb
added
bug
The issue is a bug, or the PR is fixing a bug
priority: high
High impact/importance bug
labels
Feb 16, 2024
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm,
stephanosio and
tejlmand
February 16, 2024 06:33
nordicjm
approved these changes
Feb 16, 2024
stephanosio
approved these changes
Feb 16, 2024
Why enable |
From the OP:
|
henrikbrixandersen
approved these changes
Feb 16, 2024
henrikbrixandersen
changed the title
cmake/compiler/gcc: use -flto only for gcc >= 4.5.0
cmake/compiler/gcc: use -flto/-fno-lto only for gcc >= 4.5.0
Feb 16, 2024
Thank you for clarifying. I have updated the title to match. |
microbuilder
approved these changes
Feb 16, 2024
Reassigned to @microbuilder to match the assignee of the PR that introduced this (#66392). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Build System
area: Toolchains
Toolchains
bug
The issue is a bug, or the PR is fixing a bug
priority: high
High impact/importance bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes commit 26c8776 ("buildsystem: Add an option to enable LTO")
Fixes the following error when compiling offsets.c
xt-xcc ERROR parsing -fno-lto: unknown flag
LTO options were introduced in gcc 4.5.0, compare:
https://gcc.gnu.org/onlinedocs/gcc-4.4.6/gcc/Option-Summary.html https://gcc.gnu.org/onlinedocs/gcc-4.5.0/gcc/Option-Summary.html