Kconfig LTO: Prevent with native simulator based targets #68732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LTO cannot be really used with the native simulator based targets neither today. When doing a partial link as we do for these targets the linker will complain if we are mixing LTO and non LTO built code, and fall back to only produce non-LTO output. (The link warning will cause twister to fail the test) Today not all inputs to this partial link are built with LTO enabled (offsets.c and the app library are not). Even if they were, the native targets are mostly a test and debugging facility, so optimizations like these are not beneficial in general. Let's just prevent selecting LTO for these targets. Signed-off-by: Alberto Escolar Piedras <[email protected]>
zephyrbot
added
Trivial
aescolar
added
bug
henrikbrixandersen
approved these changes
Feb 8, 2024
cvinayak
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LTO cannot be really used with the native simulator based targets today.
When doing a partial link as we do for these targets the linker will complain if we are mixing LTO and non LTO built code, and fall back to only produce non-LTO output.
(And the link warning will cause twister to fail if LTO is enabled in a sample/test)
Today not all inputs to this partial link are built with LTO enabled (offsets.c and the app library are not).
Even if they were, the native targets are mostly a test and debugging facility, so optimizations like these are not beneficial in general.
Let's just prevent selecting LTO for these targets.
Fixes #68737