-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arch: arm, arm64: Disable swi_tables.ld file when not required #68530
arch: arm, arm64: Disable swi_tables.ld file when not required #68530
Conversation
9fc4528
to
66dc7a6
Compare
66dc7a6
to
0967179
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For other to understand and for future references, then this is imprecise:
With this prefix the build works only for Ninja and does not
work propery for other build tools.
Please include something like the following information:
Linking in Zephyr / CMake.
- Ninja invokes linking directly from
<build>
.- Make invokes linking form
<build>/zephyr
.The linker default uses cwd for looking up INCLUDE directives if not found in list of includes.
Zephyr always adds<build>/zephyr
as link include using CMake,
and this is passed to ld as-L<build>/zephyr
therefore usingINCLUDE isr_tables_swi.ld
ensures it will be correctly found in all cases.
0967179
to
616d8d8
Compare
This commit removes the need of swi_tables.ld file if the ISR table generator is not configured to use it. Signed-off-by: Radosław Koppel <[email protected]>
I made a comment in the original PR, but these changes are important enough they really need to go into the release notes. A separate PR can be raised for that, though. |
This fix removes the zephyr/ prefix from linker included files. With this prefix the build works only for Ninja and not for other build tools. Linking in Zephyr / CMake: - Ninja invokes linking directly from <build>. - Make invokes linking form <build>/zephyr. The linker default uses cwd for looking up INCLUDE directives if not found in list of includes. Zephyr always adds <build>/zephyr as link include using CMake, and this is passed to ld as -L<build>/zephyr therefore using INCLUDE isr_tables_swi.ld ensures it will be correctly found in all cases. Signed-off-by: Radosław Koppel <[email protected]>
bc1573a
616d8d8
to
bc1573a
Compare
And fixed spaces. But please take a note that we are not consistent about defined and space after it. Personally I prefer it anyway how @pdgendt suggested - just aligned previously my style to the one found in the near surrounding. |
Here is proposal: #68542 68542 |
This commit removes the need of swi_tables.ld file if the ISR table generator is not configured to use it.
Fixes #68508