Bluetooth: Mesh: Change no-opcode error message log level and allow custom RPL use settings work #66228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows a custom RPL use pending mechanism and the mesh settings work to store pending RPL entries. `bt_mesh_rpl_pending_store` is a public API and should be implemented anyway. The custom RPL implementation has to trigger settings with the `BT_MESH_SETTINGS_RPL_PENDING` flag to ask the mesh settings work to call `bt_mesh_rpl_pending_store`. Signed-off-by: Pavel Vasilyev <[email protected]>
This error message may confuse when `CONFIG_BT_MESH_ACCESS_LAYER_MSG` is enabled and all messages are processed by the callback anyway. This error message also confuses when a node is subscribed to the same address as it publishes to, which makes it generating the error message every time it publishes a message. Signed-off-by: Pavel Vasilyev <[email protected]>
zephyrbot
requested review from
akredalen,
alxelax,
Andrewpini,
jhedberg and
LingaoM
PavelVPV
changed the title
alxelax
reviewed
Dec 6, 2023
alxelax
approved these changes
Dec 6, 2023
LingaoM
approved these changes
Dec 7, 2023
Andrewpini
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes 2 things:
bt_mesh_rpl_pending_storeis a public API and should be implemented anyway. The custom RPL implementation has to trigger settings with theBT_MESH_SETTINGS_RPL_PENDINGflag to ask the mesh settings work to callbt_mesh_rpl_pending_store.CONFIG_BT_MESH_ACCESS_LAYER_MSGis enabled and all messages are processed by the callback anyway.This error message also confuses when a node is subscribed to the same address as it publishes to, which makes it generating the error message every time it publishes a message.