-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: eth_nxp_s32_netc: si: use instance-based DT macros #65389
Merged
carlescufi
merged 1 commit into
zephyrproject-rtos:main
from
nxp-zephyr:nxp-s32-dt-inst-netc
Dec 11, 2023
Merged
drivers: eth_nxp_s32_netc: si: use instance-based DT macros #65389
carlescufi
merged 1 commit into
zephyrproject-rtos:main
from
nxp-zephyr:nxp-s32-dt-inst-netc
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
bperseghetti,
danieldegrasse,
Dat-NguyenDuy,
dbaluta,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
iuliana-prodan,
mmahadevan108,
PetervdPerk-NXP and
yvanderv
November 17, 2023 02:22
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nxp
DNM
This PR should not be merged (Do Not Merge)
labels
Nov 17, 2023
please include some test evidence running with PSI/VSI configurations https://github.com/zephyrproject-rtos/zephyr/tree/main/samples/boards/nxp_s32/netc |
manuargue
requested changes
Nov 30, 2023
manuargue
requested changes
Dec 5, 2023
manuargue
requested changes
Dec 6, 2023
At present, many of the NXP S32 shim drivers do not make use of devicetree instance-based macros because the NXP S32 HAL relies on an index-based approach, requiring knowledge of the peripheral instance index during both compilation and runtime, and this index might not align with the devicetree instance index. The proposed solution in this patch eliminates this limitation by determining the peripheral instance index during compilation through macrobatics and defining the handler of SI Rx event within the shim driver itself. Signed-off-by: Cong Nguyen Huu <[email protected]>
Dat-NguyenDuy
approved these changes
Dec 9, 2023
manuargue
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, many of the NXP S32 shim drivers do not make use of devicetree instance-based macros because the NXP S32 HAL relies on an index-based approach, requiring knowledge of the peripheral instance index during both compilation and runtime, and this index might not align with the devicetree instance index.
The proposed solution in this patch eliminates this limitation by determining the peripheral instance index during compilation through macrobatics.