modules liblc3: Add missing REQUIRES_FULL_LIBC Kconfig dependency #64697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aescolar
requested review from
alwa-nordic,
jhedberg,
Vudentz,
sjanc and
nashif
as code owners
aescolar
added
the
Trivial
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
hermabe,
kartben and
MariuszSkamra
Thalley
previously approved these changes
Nov 1, 2023
There was a problem hiding this comment.
This was originally rejected in #49649 by @Casper-Bonde-Bose , but I think @aescolar have convinced me that it still makes sense.
Either the LIBLC3 library needs it, and should select it, or it doesn't and shouldn't required it for the nRF5340 appcore
kartben
previously approved these changes
Nov 2, 2023
MariuszSkamra
previously approved these changes
Nov 2, 2023
The LC3 coded requires floating point support in the C library, so let's select REQUIRES_FULL_LIBC in the module kconfig, instead of having samples adding it to their prj.conf Signed-off-by: Alberto Escolar Piedras <[email protected]>
As now this is handled by the LIBLC3 kconfig Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar
dismissed stale reviews from MariuszSkamra, kartben, and Thalley
via
9f3ead4
aescolar
force-pushed
the
libc3_fulllibc
branch
from
13c5766 to
9f3ead4
Compare
|
Just a rebase to fix merge conflicts, no changes otherwise |
Thalley
approved these changes
Nov 3, 2023
kartben
approved these changes
Nov 5, 2023
|
@kartben @MariuszSkamra Thank you very much for your reviews. You'd be very welcome to reapprove as your reviews got dismissed during the rebase. |
kartben
approved these changes
Nov 5, 2023
MariuszSkamra
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LC3 codec requires floating point support in
the C library, so let's select REQUIRES_FULL_LIBC
in the module kconfig, instead of having samples
adding it to their prj.conf
Some extra info:
Today the default embedded C library is picolibc, even if REQUIRES_FULL_LIBC is not set.
REQUIRES_FULL_LIBC just prevents MINIMAL_LIBC, which is actually bigger in footprint than picolibc.