Bluetooth: shell: host: add missing conditional compile #64692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruithofa
force-pushed
the
shell_add_cond_compile
branch
from
7b30070 to
67675d8
Compare
kruithofa
requested review from
jhedberg,
Vudentz,
Thalley and
sjanc
as code owners
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
larsgk and
MariuszSkamra
|
Nitpick: could you use “Add” instead of “added” in the commit subject? That’s the common form for verbs when writing zephyr commit messages. |
Additionally, could you also add "shell" in the commit title, as this only affects the shell, and not the host stack itself. |
MariuszSkamra
requested changes
Nov 3, 2023
kruithofa
changed the title
There was a conditional compile misssing for the BT_PER_ADV_SYNC_TRANSFER_SENDER, potentially leading to build failures Signed-off-by: Andries Kruithof <[email protected]>
kruithofa
force-pushed
the
shell_add_cond_compile
branch
from
67675d8 to
a635156
Compare
Thalley
approved these changes
Nov 3, 2023
MariuszSkamra
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a conditional compile misssing for the
BT_PER_ADV_SYNC_TRANSFER_SENDER, potentially leading to build failures