Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: tester: Add support for BASS #64666

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

mkasenberg
Copy link
Contributor

No description provided.

@mkasenberg mkasenberg force-pushed the bap-broadcast-bass branch 3 times, most recently from ad29b38 to 0315fcf Compare November 9, 2023 09:40
@mkasenberg mkasenberg marked this pull request as ready for review November 9, 2023 09:56
Copy link
Collaborator

@Thalley Thalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good with some comments

tests/bluetooth/tester/src/btp/btp_bap.h Outdated Show resolved Hide resolved
tests/bluetooth/tester/src/btp/btp_bap.h Outdated Show resolved Hide resolved
tests/bluetooth/tester/src/btp/btp_bap.h Show resolved Hide resolved
tests/bluetooth/tester/src/btp_bap.c Show resolved Hide resolved
tests/bluetooth/tester/src/btp_bap.c Outdated Show resolved Hide resolved
tests/bluetooth/tester/src/btp_bap.c Outdated Show resolved Hide resolved
tests/bluetooth/tester/src/btp_bap.c Show resolved Hide resolved
tests/bluetooth/tester/src/btp_bap.c Outdated Show resolved Hide resolved
tests/bluetooth/tester/src/btp_gap.c Outdated Show resolved Hide resolved
tests/bluetooth/tester/src/btp_gap.c Outdated Show resolved Hide resolved
@mkasenberg mkasenberg force-pushed the bap-broadcast-bass branch 2 times, most recently from 2c6d3f6 to c248a91 Compare November 10, 2023 17:02
uint8_t advertiser_sid;
uint16_t skip;
uint16_t sync_timeout;
bool past_avail;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w.r.t. bool vs uint8_t that was a question and not a request for change :D

Does the BTP support using bool? If so, I think we have quite a few commands and events that could benefit from moving from uint8_t to bool.

Since bool is not necessarily a well defined type in all case, it's also understandable if we kept using uint8_t as that is well defined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In BTP spec the bool variable is defined as 1 octet and the zephyr tester is built with bool as 1 octet, so it's fine either way.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case then I'd suggest to either use bool for all boolean values (looks like this PR adds a few other still defined as uint8_t, or keep using uint8_t for all bools and update it later if wanted.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep it as uint8_t :-)

tests/bluetooth/tester/src/btp_bap.c Outdated Show resolved Hide resolved
Thalley
Thalley previously approved these changes Nov 14, 2023
Thalley
Thalley previously approved these changes Nov 14, 2023
Support for BAP/BASS and BASS test cases.

Signed-off-by: Magdalena Kasenberg <[email protected]>
@mkasenberg
Copy link
Contributor Author

I removed the BTP BASS service as there were no commands there, saving one BTP ID for future.

@mkasenberg
Copy link
Contributor Author

@sjanc

@carlescufi carlescufi merged commit 17b39ba into zephyrproject-rtos:main Nov 20, 2023
15 checks passed
@mkasenberg mkasenberg deleted the bap-broadcast-bass branch December 14, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants