-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bluetooth: tester: Add support for BASS #64666
bluetooth: tester: Add support for BASS #64666
Conversation
ad29b38
to
0315fcf
Compare
0315fcf
to
fd66f7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good with some comments
2c6d3f6
to
c248a91
Compare
uint8_t advertiser_sid; | ||
uint16_t skip; | ||
uint16_t sync_timeout; | ||
bool past_avail; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w.r.t. bool
vs uint8_t
that was a question and not a request for change :D
Does the BTP support using bool
? If so, I think we have quite a few commands and events that could benefit from moving from uint8_t
to bool
.
Since bool
is not necessarily a well defined type in all case, it's also understandable if we kept using uint8_t
as that is well defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In BTP spec the bool variable is defined as 1 octet and the zephyr tester is built with bool as 1 octet, so it's fine either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case then I'd suggest to either use bool
for all boolean values (looks like this PR adds a few other still defined as uint8_t
, or keep using uint8_t
for all bools and update it later if wanted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep it as uint8_t :-)
9c8ae2c
to
921889c
Compare
Support for BAP/BASS and BASS test cases. Signed-off-by: Magdalena Kasenberg <[email protected]>
921889c
to
022ce35
Compare
I removed the BTP BASS service as there were no commands there, saving one BTP ID for future. |
No description provided.