drivers: ipm: remove nxp,imx-mu-rev2 compatible #64662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove nxp,imx-mu-rev2 compatible. This IP block is the same as the nxp,imx-mu device, and should be handled by the same compatible Instead, use CONFIG_HAS_MCUX to determine which HAL APIs should be used to interact with the messaging unit IP. Signed-off-by: Daniel DeGrasse <[email protected]>
danieldegrasse
requested review from
mmahadevan108,
dleach02,
iuliana-prodan and
dbaluta
as code owners
zephyrbot
added
area: Xtensa
zephyrbot
requested review from
andyross,
bperseghetti,
ceolin,
dcpleung,
decsny,
DerekSnell,
EmilioCBen,
manuargue,
nashif,
PetervdPerk-NXP and
yvanderv
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nxp
DNM
dcpleung
previously approved these changes
Oct 31, 2023
| @@ -6,7 +6,6 @@ zephyr_library() | |||
|
|
|||
| zephyr_library_sources_ifdef(CONFIG_IPM_MCUX ipm_mcux.c) | |||
There was a problem hiding this comment.
I think there's a typo in commit message here: "The
driver can now be enabled with CONFIG_IPM_IMX_REV2." - s/CONFIG_IPM_IMX_REV2/_CONFIG_IPM_IMX
There was a problem hiding this comment.
There is, thanks for noticing. I've updated the PR
iuliana-prodan
previously approved these changes
Nov 1, 2023
dleach02
previously approved these changes
Nov 2, 2023
|
@danieldegrasse , please update |
Remove CONFIG_IPM_IMX_REV2, as this Kconfig is no longer needed. The driver can now be enabled with CONFIG_IPM_IMX. Update NXP HAL to remove this Kconfig as well. Signed-off-by: Daniel DeGrasse <[email protected]>
danieldegrasse
dismissed stale reviews from dleach02, iuliana-prodan, and dcpleung
via
507059e
Done, thanks |
mmahadevan108
approved these changes
Nov 3, 2023
dcpleung
approved these changes
Nov 3, 2023
iuliana-prodan
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
nxp,imx-mu-rev2compatible. Thenxp,imx-mucompatible already handles the same hardware, so we can simply useCONFIG_HAS_MCUXto detect when we need to use legacy i.MX HAL APIs, versus when we can use MCUX HAL API for the messaging unit.