Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: gpio: gpio_pca953x: Adding input latch and interrupt mask #64509

Merged
merged 1 commit into from
Dec 15, 2023
Merged

drivers: gpio: gpio_pca953x: Adding input latch and interrupt mask #64509

merged 1 commit into from
Dec 15, 2023

Conversation

VuDangBP
Copy link
Contributor

The gpio_pca953x gpio driver doesn't have
the input latch and interrupt mask
configuration which causes a lack of accessing
and using those features on an gpio expander
device. Fix it by adding input latch and
interrupt mask configurations in this driver.

@VuDangBP VuDangBP requested review from galak and mnkp as code owners October 27, 2023 15:16
@zephyrbot zephyrbot added area: GPIO area: Devicetree Binding PR modifies or adds a Device Tree binding platform: TI SimpleLink Texas Instruments SimpleLink MCU labels Oct 27, 2023
@github-actions
Copy link

Hello @VuDangBP, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@VuDangBP VuDangBP force-pushed the gpio_pca953x_changes branch 4 times, most recently from a22ceca to 553e8b6 Compare November 1, 2023 16:15
@VuDangBP VuDangBP force-pushed the gpio_pca953x_changes branch from 553e8b6 to 1dbdb91 Compare November 7, 2023 09:57
@VuDangBP VuDangBP force-pushed the gpio_pca953x_changes branch from 1dbdb91 to eea60a8 Compare November 20, 2023 15:04
@cfriedt cfriedt removed their request for review November 28, 2023 12:44
@nordicjm
Copy link
Collaborator

CC @rerickson1 long memory but this doesn't look valid for the BL5340 DVK port expander

@VuDangBP VuDangBP force-pushed the gpio_pca953x_changes branch from eea60a8 to f9cd640 Compare November 29, 2023 12:55
rerickson1
rerickson1 requested changes Nov 29, 2023
View reviewed changes
drivers/gpio/gpio_pca953x.c Outdated Show resolved Hide resolved
@rerickson1
Copy link
Member

CC @rerickson1 long memory but this doesn't look valid for the BL5340 DVK port expander

@nordicjm could you clarify your thinking here? Why wouldn't it work? I will start looking into this as well. Thanks!

@nordicjm
Copy link
Collaborator

CC @rerickson1 long memory but this doesn't look valid for the BL5340 DVK port expander

@nordicjm could you clarify your thinking here? Why wouldn't it work? I will start looking into this as well. Thanks!

They don't exist in that part: https://www.ti.com/lit/ds/symlink/tca9538.pdf

rerickson1
rerickson1 requested changes Nov 29, 2023
View reviewed changes
dts/bindings/gpio/ti,tca9538.yaml Outdated Show resolved Hide resolved
rerickson1
rerickson1 requested changes Dec 4, 2023
View reviewed changes
drivers/gpio/gpio_pca953x.c Outdated Show resolved Hide resolved
rerickson1
rerickson1 previously approved these changes Dec 4, 2023
View reviewed changes
@VuDangBP
Copy link
Contributor Author

VuDangBP commented Dec 8, 2023

Hi @rerickson1, as there is a new commit added to this PR, please review this PR. Thank you very much.

rerickson1
rerickson1 requested changes Dec 8, 2023
View reviewed changes
Copy link
Member

@rerickson1 rerickson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces missing here.

rerickson1
rerickson1 requested changes Dec 8, 2023
View reviewed changes
Copy link
Member

@rerickson1 rerickson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all commits.

rerickson1
rerickson1 previously approved these changes Dec 11, 2023
View reviewed changes
@VuDangBP VuDangBP force-pushed the gpio_pca953x_changes branch 2 times, most recently from 259f56d to 62607ad Compare December 12, 2023 15:54
rerickson1
rerickson1 previously approved these changes Dec 12, 2023
View reviewed changes
@VuDangBP VuDangBP force-pushed the gpio_pca953x_changes branch from 62607ad to 152ebe6 Compare December 12, 2023 17:16
rerickson1
rerickson1 previously approved these changes Dec 12, 2023
View reviewed changes
ycsin
ycsin reviewed Dec 14, 2023
View reviewed changes
drivers/gpio/gpio_pca953x.c Outdated Show resolved Hide resolved
drivers/gpio/gpio_pca953x.c Outdated Show resolved Hide resolved
@VuDangBP VuDangBP force-pushed the gpio_pca953x_changes branch from 152ebe6 to 838baf0 Compare December 14, 2023 10:43
@rerickson1 rerickson1 requested a review from ycsin December 14, 2023 13:06
rerickson1
rerickson1 previously approved these changes Dec 14, 2023
View reviewed changes
ycsin
ycsin previously approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, good to remove that empty line if there's another revision

dts/bindings/gpio/ti,tca9538.yaml Outdated Show resolved Hide resolved
fabiobaltieri
fabiobaltieri requested changes Dec 15, 2023
View reviewed changes
dts/bindings/gpio/ti,tca9538.yaml Outdated Show resolved Hide resolved
@VuDangBP
drivers: gpio: gpio_pca953x: Adding input latch and interrupt mask
c291e15 
The gpio_pca953x gpio driver doesn't have
the input latch and interrupt mask
configuration which causes a lack of accessing
and using those features on an gpio expander
device. Fix it by adding input latch and
interrupt mask configurations in this driver.

Signed-off-by: Vudang Thaihai <[email protected]>
@VuDangBP VuDangBP force-pushed the gpio_pca953x_changes branch from 838baf0 to c291e15 Compare December 15, 2023 11:24
fabiobaltieri
fabiobaltieri approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience :-)

@fabiobaltieri fabiobaltieri merged commit cf5781a into zephyrproject-rtos:main Dec 15, 2023
16 checks passed
@github-actions GitHub Actions
Copy link

Hi @VuDangBP!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@galak galak Awaiting requested review from galak

@mnkp mnkp Awaiting requested review from mnkp

@vaishnavachath vaishnavachath Awaiting requested review from vaishnavachath

@vanti vanti Awaiting requested review from vanti

@ycsin ycsin Awaiting requested review from ycsin

@rerickson1 rerickson1 Awaiting requested review from rerickson1

Assignees

@vaishnavachath vaishnavachath

Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: GPIO platform: TI SimpleLink Texas Instruments SimpleLink MCU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@VuDangBP @nordicjm @rerickson1 @fabiobaltieri @henrikbrixandersen @ycsin @zephyrbot @vaishnavachath