Bluetooth testing bsim: Add BT split stack tests support and some tests in CI #64450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aescolar
force-pushed
the
bsim_split_test
branch
2 times, most recently
from
a803450 to
5496579
Compare
aescolar
changed the title
aescolar
force-pushed
the
bsim_split_test
branch
from
5496579 to
282f066
Compare
aescolar
force-pushed
the
bsim_split_test
branch
from
282f066 to
bd0a3cc
Compare
aescolar
requested review from
alwa-nordic,
jhedberg,
Vudentz,
wopu-ot,
nashif,
carlescufi,
cvinayak,
thoh-ot,
kruithofa and
galak
as code owners
zephyrbot
added
platform: nRF BSIM
zephyrbot
requested review from
asbjornsabo,
erbr-ot,
hermabe,
mtpr-ot and
Thalley
Add support for sysbuild builds, which can be selected by settings the variable sysbuild. Signed-off-by: Alberto Escolar Piedras <[email protected]>
Add sysbuild build files, which allows building this test both for the targets we could already before (nrf52_bsim & nrf5340bsim_nrf5340_cpunet) and also adds support for the a split build with the nrf5340bsim_nrf5340_cpuapp. Note that when doing a split build the controller is taken from the hci_rpmsg BT sample, and therefore the controller configuration in this folder is not used. Signed-off-by: Alberto Escolar Piedras <[email protected]>
Add sysbuild build files, which allows building this test both for the targets we could already before (nrf52_bsim & nrf5340bsim_nrf5340_cpunet) and also adds support for the a split build with the nrf5340bsim_nrf5340_cpuapp. Signed-off-by: Alberto Escolar Piedras <[email protected]>
Note just those called exactly compile.sh Signed-off-by: Alberto Escolar Piedras <[email protected]>
With TESTS_FILE the user could provide a file with a list of tests to run. Now we also support that file containing a mix of tests and paths in which to search for tests. Signed-off-by: Alberto Escolar Piedras <[email protected]>
Also run some split BT stack tests on the nrf5340 platform to test this configuration. Move the selection of which BT tests are built and run in each platform to files in the tests/bsim/ folder. Signed-off-by: Alberto Escolar Piedras <[email protected]>
The test was printing one line for each packet it was sending by default. That creates a huge log and slows things down. Instead, let's only print those with verbosity set at 4 or higher. Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar
force-pushed
the
bsim_split_test
branch
from
bd0a3cc to
e357213
Compare
aescolar
changed the title
cvinayak
approved these changes
Oct 31, 2023
Thalley
reviewed
Oct 31, 2023
Thalley
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Adding support for the split builds with sysbuild does not affect the ability to build without sysbuild, either for the nrf52bsim or other targets. It remains possible to use the compile and run_parallel scripts as before with the nr52bsim or out of tree boards.