-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: adc: ltc2451: Add ltc2451 driver #64390
drivers: adc: ltc2451: Add ltc2451 driver #64390
Conversation
f0a0587
to
5d87b5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. Only got some minor suggestions for improvement.
87ec3f0
to
6620097
Compare
0da7d8d
to
a6ccdef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The driver needs to be added to the build_all
unit tests by adding a devicetree node to tests/drivers/build_all/adc/app.overlay
. See the recently merged #64592 as an example.
7c3e540
to
13fc81e
Compare
13fc81e
to
084f702
Compare
084f702
to
e950b48
Compare
e950b48
to
3fd0868
Compare
3fd0868
to
d3b8888
Compare
Adds support for the Linear Technologies LTC2451 ADC. Signed-off-by: Ethan Duckett <[email protected]>
d3b8888
to
469a795
Compare
Thank you for the reviews guys, hopefully once this pipeline has finished we should be good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ethan-duckett-brill for the patience :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds support for the Linear Technologies LTC2451 ADC.