[Backport v3.5-branch] Keep tcp context valid for the whole connection duration #64286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase reference count already when initial SYN is sent. This way the tcp pointer in net_context is fully valid for the duration of the connection. Fixes #63952 Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit fd1c226)
Return the last socket error to user. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit b864880)
If we try to connect to a port which no socket is listening to, we will get a packet with "ACK | RST" flags set. In this case the errno should be ECONNREFUSED instead of ETIMEDOUT like we used to return earlier. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit ec4973d)
The writefds is typically set if there is an error while waiting for example the connect() to finish. So check if the user supplied the writefds and update it accordingly. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit 5bf18e3)
This checks that if connect() timeouts, we check TCP pointer properly in select() and poll() in order to catch the situation. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit b510073)
zephyrbot
added
Backport
|
The network tests that are failing in this PR need this one applied first #64029. |
jhedberg
approved these changes
Oct 24, 2023
jukkar
approved these changes
Nov 2, 2023
fabiobaltieri
approved these changes
Nov 2, 2023
rlubos
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b510073~5..b510073 from #63984.
Fixes #63952