Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.4] type corrections for sigval sigevent notify #64273

Conversation

cfriedt
Copy link
Member

@cfriedt cfriedt commented Oct 23, 2023

Backport of #61398 to v3.4-branch.

Fixes #60957
Fixes #61783

* `struct sigevent` is not type-defined
* `union sigval` is not type-defined
* `struct sigevent` must include `sigev_notify_attributes`

For more information, see https://bit.ly/3YfnELI

Signed-off-by: Christopher Friedt <[email protected]>
(cherry picked from commit 9f1e4fa)
The `<zephyr/posix/time.h>` header was unused in `fpga_ice40.c`
so remove it.

This fixes an error about `pthread_attr_t` not being defined.

Signed-off-by: Christopher Friedt <[email protected]>
(cherry picked from commit 64e6c90)
When compiling for ARCH_POSIX, include `time.h` rather than
`posix/time.h`.

Signed-off-by: Christopher Friedt <[email protected]>
(cherry picked from commit e6c6d82)
@cfriedt cfriedt requested review from nashif, henrikbrixandersen, jgl-meta and a team October 23, 2023 17:04
@cfriedt cfriedt self-assigned this Oct 23, 2023
@cfriedt
Copy link
Member Author

cfriedt commented Oct 26, 2023

@jgl-meta @nashif - compliance check is a false positive.

@cfriedt cfriedt marked this pull request as ready for review October 26, 2023 13:09
@zephyrbot zephyrbot added area: Shell Shell subsystem area: FPGA Field-Programmable Gate Array (FPGA) area: POSIX POSIX API Library labels Oct 26, 2023
@henrikbrixandersen henrikbrixandersen added the Backport Backport PR and backport failure issues label Oct 27, 2023
@cfriedt cfriedt requested a review from ycsin October 31, 2023 00:18
@cfriedt cfriedt merged commit 9a6e87a into zephyrproject-rtos:v3.4-branch Oct 31, 2023
23 of 24 checks passed
@cfriedt cfriedt deleted the v3.4-type-corrections-for-sigval-sigevent-notify branch November 22, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: FPGA Field-Programmable Gate Array (FPGA) area: POSIX POSIX API Library area: Shell Shell subsystem Backport Backport PR and backport failure issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants