Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: arm: LPC55Sx6: Enable LinkServer and PyOCD runners. #63753

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

butok
Copy link
Contributor

@butok butok commented Oct 10, 2023

Enable LinkerServer and PyOCD runners for LPC55Sx6 EVKs, where it is supported.
It was tested on a real HW.

Enable LinkerServer and PyOCD runners for LPC55Sx6 EVKs,
where it is supported.
It was tested on a real HW.

Signed-off-by: Andrej Butok <[email protected]>
@butok
Copy link
Contributor Author

butok commented Oct 30, 2023

UP

Copy link
Collaborator

@danieldegrasse danieldegrasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will change the default runner for these boards to be Linkserver. Please update the documentation for these boards to clarify that the default runner is now Linkserver- see the RT1170 documentation page for an example of how we document Linkserver usage: https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/arm/mimxrt1170_evk/doc/index.rst#using-linkserver (note that on this board we will not need to set the runner to linkserver with -r

@danieldegrasse danieldegrasse dismissed their stale review October 31, 2023 16:18

I was wrong- the linkserver debugger definition will not set itself as the default, so the board default here is still JLink

Copy link
Collaborator

@danieldegrasse danieldegrasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the board documentation for these boards to call out that Linkserver is now supported as a runner? You can look at the RT1170 doc page I linked for an example

boards/arm/lpcxpresso55s16/board.cmake Show resolved Hide resolved
@mmahadevan108
Copy link
Collaborator

@butok , this looks good. Can you please update the board documentation to indicate this support.

@butok
Copy link
Contributor Author

butok commented Nov 16, 2023

@butok , this looks good. Can you please update the board documentation to indicate this support.

It is needed to prove that LinkServer is mature enough.
My plan:

If failed, to reformat/cancel this commit and to leave jlink as a default runner.

@carlescufi carlescufi merged commit 3b5fd5f into zephyrproject-rtos:main Nov 16, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants