Bluetooth: BAP: Scan delegator missing state change for bis_sync #63745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the bis_sync value changes, that should trigger a state change notification. Signed-off-by: Emil Gydesen <[email protected]>
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
kruithofa,
larsgk and
MariuszSkamra
jhedberg
previously approved these changes
Oct 10, 2023
For some reason the state_change variable was static, which does not make any sense. Changed it to a regular local bool in bt_bap_scan_delegator_mod_src. Signed-off-by: Emil Gydesen <[email protected]>
|
Fixed another issue with the |
fredrikdanebjer
approved these changes
Oct 12, 2023
larsgk
approved these changes
Oct 12, 2023
jhedberg
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the bis_sync value changes, that should trigger a state change notification.
fixes #63744