Bluetooth: ascs: Check subscription state on ASE notification #63737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check whether peer is subscribed for ASE state notification before calling bt_gatt_notify. This handles an assert thrown when the notification failed to be sent. Fixes: zephyrproject-rtos#63728 Signed-off-by: Mariusz Skamra <[email protected]>
MariuszSkamra
requested review from
jhedberg,
Vudentz,
wopu-ot,
Thalley and
sjanc
as code owners
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
kruithofa and
larsgk
Thalley
approved these changes
Oct 10, 2023
larsgk
approved these changes
Oct 11, 2023
fabiobaltieri
approved these changes
Oct 12, 2023
|
@Thalley same with this one and the linked issue being an enhancement. I'll remove the 3.5 milestone for now, but let me know if this is something more than an enhancement. |
|
@MariuszSkamra You raised the issue an enhancement rather than a bug, although an unexpected __ASSERT would mean a bug in my eyes - Do you agree? |
jhedberg
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check whether peer is subscribed for ASE state notification before calling bt_gatt_notify. This handles an assert thrown when the notification failed to be sent.
Fixes: #63728