drivers: ncp5623: Fix error check

[finikorg]

num_colors cannot be not equal to different values at the same time.

[simonguinot]

Thanks for spotting this.

In addition I think the code should rather be:

if (led_info->num_colors != NCP5623_CHANNEL_COUNT) {
                LOG_ERR("%s: invalid number of colors %d (must be %d when defining a single LED)",
                                  dev->name, led_info->num_colors, NCP5623_CHANNEL_COUNT);
}

@PetervdPerk-NXP, please can you have a look ?

[PetervdPerk-NXP]

It was for the weird edge where one would be attaching one singe color led to the ncp5623.
@simonguinot suggestion to just enforce 3 colors in single led rgb mode would make more sense.

[finikorg]

Fixed proposed way.

[simonguinot]

Thanks for taking care @finikorg !

[bbilas]

Shouldn't we return any errno in that case?

[jhedberg]

Shouldn't we return any errno in that case?

Yeah, at least to me it seems like return -EINVAL would be the right thing (and consistent with how the function is dealing with other similar errors).

[simonguinot]

Let's prevent this to be merged before return is added.

[simonguinot]

Shouldn't we return any errno in that case?

Well spotted !

[simonguinot]

Thanks !

[jhedberg]

Looks good, however since we're at the last stages of the release, it's unlikely this will get merged before 3.5 (would require that it's fixing a release blocker issue)