-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: build/config/settings fix confusing descriptions #63725
Conversation
Though please fix the commit message, remove the link to the issue and fix the commit message as per https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-message-guidelines |
How can I continue editing the commit message from within web browser? |
You need to do it from command line with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
The changes looks good, but you need to rebase your commit and get rid of the merge-commit.
See more here: https://docs.zephyrproject.org/latest/contribute/guidelines.html#contribution-workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Please see my comment, and use git commit --amend --author="Author Name <[email protected]>"
to fix your current commit so that it has the same author as the one specified in the Signed-off-by entry. Based on how much you want to actually exercise your git skills w.r.t rebasing, and because it's a pretty small change, you might find it easier to reset your branch to main and work your way through the two commits by re-starting form scratch though.
Thanks again!
use unnumbered list to align with guidelines Signed-off-by: Yanfeng Liu <[email protected]>
make item#2 as part of item#1 to reduce confusions. Signed-off-by: Yanfeng Liu <[email protected]>
this is fixed in my latest push. |
commit messages have been fixed in my latest push. |
Please don't close it! Next step is for one of our release engineers to do the merge, which should happen momentarily now that I have set the target milestone to 3.5. |
Hi @yf13! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
rearrange point 2 as part of point 1, then update order of following points